Skip to content

move hook and store test#1021

Merged
mcalhoun merged 1 commit intomainfrom
move-hook-and-store-test
Feb 4, 2025
Merged

move hook and store test#1021
mcalhoun merged 1 commit intomainfrom
move-hook-and-store-test

Conversation

@mcalhoun
Copy link
Contributor

@mcalhoun mcalhoun commented Feb 4, 2025 •
edited
Loading

what

  • Relocated test fixtures from testdata/fixtures/hooks-test to tests/fixtures/scenarios/hooks-test
  • Renamed test components from random1/random2 to component1/component2 for better clarity
  • Updated component path from random to hook-and-store to better reflect its functionality
  • Fixed typo in test comment ("deeploy" to "deploy")

why

  • Improves test organization by moving fixtures to a more standardized location
  • Makes test components and their purposes more self-documenting through better naming
  • Aligns component names with their actual functionality (hook and store operations)
  • Enhances code readability and maintainability

references

  • No external references or issues to link

@mcalhoun mcalhoun mentioned this pull request Feb 4, 2025
Merged
@mcalhoun Graphite App
Copy link
Contributor Author

mcalhoun commented Feb 4, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mergify mergify bot added the triage Needs triage label Feb 4, 2025
@mcalhoun mcalhoun marked this pull request as ready for review February 4, 2025 17:32
@mcalhoun mcalhoun requested review from a team as code owners February 4, 2025 17:32
@mcalhoun mcalhoun added the no-release Do not create a new release (wait for additional code changes) label Feb 4, 2025 — with Graphite App
@mcalhoun mcalhoun self-assigned this Feb 4, 2025
@mcalhoun mcalhoun removed the triage Needs triage label Feb 4, 2025
@mcalhoun mcalhoun changed the base branch from add-store-defaults to graphite-base/1021 February 4, 2025 17:37
@mcalhoun mcalhoun force-pushed the move-hook-and-store-test branch from 073e2e8 to 2597dfa Compare February 4, 2025 17:37
@mcalhoun mcalhoun changed the base branch from graphite-base/1021 to main February 4, 2025 17:37
@mcalhoun mcalhoun merged commit 02859b2 into main Feb 4, 2025
80 checks passed
@mcalhoun mcalhoun deleted the move-hook-and-store-test branch February 4, 2025 17:59
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

These changes were released in v1.159.0.

Cerebrovinny pushed a commit that referenced this pull request Feb 9, 2025
@Cerebrovinny
move hook and store test (#1021)
020efc3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mcalhoun mcalhoun

Labels

no-release Do not create a new release (wait for additional code changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mcalhoun