Increase the memory threshold used in memory-leak tests #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Jan 29, 2020
ogrisel
approved these changes
Feb 2, 2020
sthagen
added a commit
to sthagen/cloudpipe-cloudpickle
that referenced
this pull request
Feb 3, 2020
Increase the memory threshold used in memory-leak tests (cloudpipe#330)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #272
As a
Pythoninterpreter uses ~10MB of memory on MacOS,test_interactive_remote_function_calls_no_memory_leakfails on this system. In the perspective of adding acloudpickleCI entry for Mac, I propose to increase the threshold above which this test fails.As a side note, we carried out some tests with @ogrisel to make sure this 10MB memory usage remains stable when increasing the load in this test, and it seems to be the case. So this issue is unlikely to be a memory leak caused by us.