feat: add kustomization for ClusterImageCatalog manifests#118
Closed
solidDoWant wants to merge 1 commit intocloudnative-pg:mainfrom
Closed
feat: add kustomization for ClusterImageCatalog manifests#118solidDoWant wants to merge 1 commit intocloudnative-pg:mainfrom
solidDoWant wants to merge 1 commit intocloudnative-pg:mainfrom
Conversation
|
Wanted to do the exact same thing. Good stuff. |
Signed-off-by: Fred Heinecke <fred.heinecke@yahoo.com>
Contributor
|
Related to cloudnative-pg/cloudnative-pg#4687. |
Contributor
|
We have now moved to a different model and catalogs are in the artifacts project. Would this still be relevant? |
Contributor
|
I am closing this. I have added a new issue to keep track of that (#309). |
Contributor
|
Merged as part of #309 - thanks for the @solidDoWant. Please test this and let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a kustomization file that always includes the latest ClusterImageCatalog manifest for the default distribution.
cdc86b7 added support for multiple Debian releases, and changed the
ClusterImageCatalog.yamlfrom a file to a symlink. This is great if you have the repo cloned, but it broke several install methods, including what's listed in the CNPG docs:kubectl apply -f https://raw.githubusercontent.com/cloudnative-pg/postgres-containers/main/Debian/ClusterImageCatalog.yaml(as listed in the docs) fails witherror validating data: invalid object to validate [...]Inclusion in a kustomization.yaml file i.e.
fails with
error: accumulating resources: accumulation err [...] missing Resource metadata': [...]Installation via flux CD with a git source fails as flux deletes symlinks for security reasons
This fixes all of the above install methods (and probably others) by adding a
kustomization.yamlfile. Users can specify this file, or in some cases the Debian directory, to install the correct manifest:kubectl apply -k kubectl apply -k https://github.com/cloudnative-pg/postgres-containers//Debian/?ref=mainInclusion in a kustomization.yaml file i.e.
Flux CD git source and Kustomization with
path: /DebianThe file will be automatically when the CD pipeline is ran, just like the symlinked
ClusterImageCatalog.yaml.