fix: enter deletion path immediately when cluster is being deleted#9555
Merged
leonardoce merged 3 commits intomainfrom Dec 23, 2025
Merged
fix: enter deletion path immediately when cluster is being deleted#9555leonardoce merged 3 commits intomainfrom
leonardoce merged 3 commits intomainfrom
Conversation
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Member
Author
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/20438239063 |
e811c21 to
d88668a
Compare
armru
approved these changes
Dec 23, 2025
leonardoce
approved these changes
Dec 23, 2025
When a cluster has DeletionTimestamp set, skip normal reconciliation and enter the deletion path immediately. This prevents accumulating exponential backoff from failed attempts to create resources in a terminating namespace. Additionally, handle optimistic locking conflicts during finalizer removal by requeueing after 1 second instead of returning an error, avoiding unnecessary backoff delays. Closes #9554 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
…9555) When a cluster has DeletionTimestamp set, skip normal reconciliation and enter the deletion path immediately. This prevents accumulating exponential backoff from failed attempts to create resources in a terminating namespace. Additionally, handle optimistic locking conflicts during finalizer removal by requeueing after 1 second instead of returning an error, avoiding unnecessary backoff delays. Closes #9554 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 36b2304)
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
…9555) When a cluster has DeletionTimestamp set, skip normal reconciliation and enter the deletion path immediately. This prevents accumulating exponential backoff from failed attempts to create resources in a terminating namespace. Additionally, handle optimistic locking conflicts during finalizer removal by requeueing after 1 second instead of returning an error, avoiding unnecessary backoff delays. Closes #9554 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 36b2304)
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
…9555) When a cluster has DeletionTimestamp set, skip normal reconciliation and enter the deletion path immediately. This prevents accumulating exponential backoff from failed attempts to create resources in a terminating namespace. Additionally, handle optimistic locking conflicts during finalizer removal by requeueing after 1 second instead of returning an error, avoiding unnecessary backoff delays. Closes #9554 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 36b2304)
mnencia
added a commit
that referenced
this pull request
Jan 20, 2026
…9555) When a cluster has DeletionTimestamp set, skip normal reconciliation and enter the deletion path immediately. This prevents accumulating exponential backoff from failed attempts to create resources in a terminating namespace. Additionally, handle optimistic locking conflicts during finalizer removal by requeueing after 1 second instead of returning an error, avoiding unnecessary backoff delays. Closes #9554 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 36b2304)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a cluster has DeletionTimestamp set, skip normal reconciliation and enter the deletion path immediately. This prevents accumulating exponential backoff from failed attempts to create resources in a terminating namespace.
Additionally, handle optimistic locking conflicts during finalizer removal by requeueing after 1 second instead of returning an error, avoiding unnecessary backoff delays.
Closes #9554