fix(backup): use correct pod name in event when pod is not found#9552
Merged
fix(backup): use correct pod name in event when pod is not found#9552
Conversation
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
04dff75 to
5ecdc28
Compare
Member
Author
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/20435444813 |
mnencia
approved these changes
Dec 22, 2025
leonardoce
approved these changes
Dec 22, 2025
In isValidBackupRunning, when the elected backup pod is not found, the event message was incorrectly referencing pod.Name which is empty since the Get() call returned NotFound. Changed to use the actual pod name from backup.Status.InstanceID.PodName which contains the name of the pod that couldn't be found. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
5ecdc28 to
dcad3ef
Compare
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
In isValidBackupRunning, when the elected backup pod is not found, the event message was incorrectly referencing pod.Name which is empty since the Get() call returned NotFound. Changed to use the actual pod name from backup.Status.InstanceID.PodName which contains the name of the pod that couldn't be found. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit ea7c496)
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 22, 2025
In isValidBackupRunning, when the elected backup pod is not found, the event message was incorrectly referencing pod.Name which is empty since the Get() call returned NotFound. Changed to use the actual pod name from backup.Status.InstanceID.PodName which contains the name of the pod that couldn't be found. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit ea7c496)
mnencia
pushed a commit
that referenced
this pull request
Dec 22, 2025
In isValidBackupRunning, when the elected backup pod is not found, the event message was incorrectly referencing pod.Name which is empty since the Get() call returned NotFound. Changed to use the actual pod name from backup.Status.InstanceID.PodName which contains the name of the pod that couldn't be found. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit ea7c496)
mnencia
pushed a commit
that referenced
this pull request
Jan 20, 2026
In isValidBackupRunning, when the elected backup pod is not found, the event message was incorrectly referencing pod.Name which is empty since the Get() call returned NotFound. Changed to use the actual pod name from backup.Status.InstanceID.PodName which contains the name of the pod that couldn't be found. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit ea7c496)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In isValidBackupRunning, when the elected backup pod is not found, the event message was incorrectly referencing pod.Name which is empty since the Get() call returned NotFound. Changed to use the actual pod name from backup.Status.InstanceID.PodName which contains the name of the pod that couldn't be found.