fix(backup): use Status().Patch for backup status updates in reconcileSnapshotBackup#9551
Merged
fix(backup): use Status().Patch for backup status updates in reconcileSnapshotBackup#9551
Conversation
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
52851cf to
1d4d46d
Compare
Member
Author
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/20435438917 |
mnencia
approved these changes
Dec 22, 2025
leonardoce
approved these changes
Dec 22, 2025
e63248f to
bd5c117
Compare
Member
|
/ok-to-merge E2E green |
…eSnapshotBackup The reconcileSnapshotBackup function was incorrectly using r.Patch() instead of r.Status().Patch() when setting backup status to pending. This is inconsistent with all other status patch operations in the controller and could cause issues since .status is a subresource that requires the status client. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
bd5c117 to
e6d078f
Compare
mnencia
pushed a commit
that referenced
this pull request
Dec 22, 2025
…eSnapshotBackup (#9551) The reconcileSnapshotBackup function was incorrectly using r.Patch() instead of r.Status().Patch() when setting backup status to pending. This is inconsistent with all other status patch operations in the controller and could cause issues since .status is a subresource that requires the status client. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 9f3c487)
mnencia
pushed a commit
that referenced
this pull request
Dec 22, 2025
…eSnapshotBackup (#9551) The reconcileSnapshotBackup function was incorrectly using r.Patch() instead of r.Status().Patch() when setting backup status to pending. This is inconsistent with all other status patch operations in the controller and could cause issues since .status is a subresource that requires the status client. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 9f3c487)
mnencia
pushed a commit
that referenced
this pull request
Dec 22, 2025
…eSnapshotBackup (#9551) The reconcileSnapshotBackup function was incorrectly using r.Patch() instead of r.Status().Patch() when setting backup status to pending. This is inconsistent with all other status patch operations in the controller and could cause issues since .status is a subresource that requires the status client. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 9f3c487)
mnencia
pushed a commit
that referenced
this pull request
Jan 20, 2026
…eSnapshotBackup (#9551) The reconcileSnapshotBackup function was incorrectly using r.Patch() instead of r.Status().Patch() when setting backup status to pending. This is inconsistent with all other status patch operations in the controller and could cause issues since .status is a subresource that requires the status client. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 9f3c487)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reconcileSnapshotBackup function was incorrectly using r.Patch() instead of r.Status().Patch() when setting backup status to pending. This is inconsistent with all other status patch operations in the controller and could cause issues since .status is a subresource that requires the status client.