fix(scheduledbackup): use label-based indexer instead of ownership#9489
Merged
leonardoce merged 1 commit intomainfrom Dec 23, 2025
Merged
fix(scheduledbackup): use label-based indexer instead of ownership#9489leonardoce merged 1 commit intomainfrom
leonardoce merged 1 commit intomainfrom
Conversation
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
4 tasks
Member
Author
|
/test |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/20435653514 |
mnencia
approved these changes
Dec 22, 2025
leonardoce
approved these changes
Dec 23, 2025
…ed indexer The ScheduledBackup controller was using a broken field indexer on owner references to find child Backups for concurrency checking. The indexer checked for the wrong owner kind, making it non-functional. This fix replaces the owner reference-based indexer with a more robust approach: a field indexer on the ParentScheduledBackupLabel that is already set on all backups created by ScheduledBackup. This label is always present regardless of the backupOwnerReference configuration. Closes #9466 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
…9489) The ScheduledBackup controller was using a broken field indexer on owner references to find child Backups for concurrency checking. The indexer checked for the wrong owner kind, making it non-functional. This fix replaces the owner reference-based indexer with a more robust approach: a field indexer on the ParentScheduledBackupLabel that is already set on all backups created by ScheduledBackup. This label is always present regardless of the backupOwnerReference configuration. Closes #9485 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 54d9c2b)
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
…9489) The ScheduledBackup controller was using a broken field indexer on owner references to find child Backups for concurrency checking. The indexer checked for the wrong owner kind, making it non-functional. This fix replaces the owner reference-based indexer with a more robust approach: a field indexer on the ParentScheduledBackupLabel that is already set on all backups created by ScheduledBackup. This label is always present regardless of the backupOwnerReference configuration. Closes #9485 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 54d9c2b)
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 23, 2025
…9489) The ScheduledBackup controller was using a broken field indexer on owner references to find child Backups for concurrency checking. The indexer checked for the wrong owner kind, making it non-functional. This fix replaces the owner reference-based indexer with a more robust approach: a field indexer on the ParentScheduledBackupLabel that is already set on all backups created by ScheduledBackup. This label is always present regardless of the backupOwnerReference configuration. Closes #9485 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 54d9c2b)
mnencia
pushed a commit
that referenced
this pull request
Jan 20, 2026
…9489) The ScheduledBackup controller was using a broken field indexer on owner references to find child Backups for concurrency checking. The indexer checked for the wrong owner kind, making it non-functional. This fix replaces the owner reference-based indexer with a more robust approach: a field indexer on the ParentScheduledBackupLabel that is already set on all backups created by ScheduledBackup. This label is always present regardless of the backupOwnerReference configuration. Closes #9485 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit 54d9c2b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ScheduledBackup controller was using a broken field indexer on owner references to find child Backups for concurrency checking. The indexer checked for the wrong owner kind, making it non-functional.
This fix replaces the owner reference-based indexer with a more robust approach: a field indexer on the ParentScheduledBackupLabel that is already set on all backups created by ScheduledBackup. This label is always present regardless of the backupOwnerReference configuration.
Closes #9485