fix: ensure pull secret is added to pooler ServiceAccount#9427
Merged
leonardoce merged 1 commit intomainfrom Dec 15, 2025
Merged
fix: ensure pull secret is added to pooler ServiceAccount#9427leonardoce merged 1 commit intomainfrom
leonardoce merged 1 commit intomainfrom
Conversation
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Member
Author
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/20207139400 |
Member
Author
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/20222763469 |
armru
approved these changes
Dec 15, 2025
When creating a new pooler ServiceAccount, the imagePullSecret was not being added because the code incorrectly passed the nil resources.ServiceAccount instead of the newly created serviceAccount variable to the ensureServiceAccountHaveImagePullSecret function. This caused pooler deployments to fail pulling images from private registries, resulting in stuck rolling updates during operator upgrades. Fixes #9426 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
3ca94d7 to
ecad176
Compare
leonardoce
approved these changes
Dec 15, 2025
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
When creating a new pooler ServiceAccount, the imagePullSecret was not being added because the code incorrectly passed the nil resources.ServiceAccount instead of the newly created serviceAccount variable to the ensureServiceAccountHaveImagePullSecret function. This caused pooler deployments to fail pulling images from private registries, resulting in stuck rolling updates during operator upgrades. Fixes #9426 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 2abbb31)
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
When creating a new pooler ServiceAccount, the imagePullSecret was not being added because the code incorrectly passed the nil resources.ServiceAccount instead of the newly created serviceAccount variable to the ensureServiceAccountHaveImagePullSecret function. This caused pooler deployments to fail pulling images from private registries, resulting in stuck rolling updates during operator upgrades. Fixes #9426 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 2abbb31)
cnpg-bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
When creating a new pooler ServiceAccount, the imagePullSecret was not being added because the code incorrectly passed the nil resources.ServiceAccount instead of the newly created serviceAccount variable to the ensureServiceAccountHaveImagePullSecret function. This caused pooler deployments to fail pulling images from private registries, resulting in stuck rolling updates during operator upgrades. Fixes #9426 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 2abbb31)
mnencia
added a commit
that referenced
this pull request
Jan 20, 2026
When creating a new pooler ServiceAccount, the imagePullSecret was not being added because the code incorrectly passed the nil resources.ServiceAccount instead of the newly created serviceAccount variable to the ensureServiceAccountHaveImagePullSecret function. This caused pooler deployments to fail pulling images from private registries, resulting in stuck rolling updates during operator upgrades. Fixes #9426 Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 2abbb31)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new pooler ServiceAccount, the imagePullSecret was not being
added because the code incorrectly passed the nil resources.ServiceAccount
instead of the newly created serviceAccount variable to the
ensureServiceAccountHaveImagePullSecret function.
This caused pooler deployments to fail pulling images from private registries,
resulting in stuck rolling updates during operator upgrades.
Fixes #9426