Conversation
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
mnencia
approved these changes
Nov 20, 2025
Previously, if the ImageCatalog CRD was missing or another error occurred during retrieval (other than NotFound), the controller would fail silently without emitting a Kubernetes event. This made troubleshooting difficult, especially when using tools like ArgoCD. This commit ensures that a Warning event and a log is emitted when the ImageCatalog cannot be retrieved for any reason, providing better visibility into configuration errors. Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Jonathan Battiato <jonathan.battiato@enterprisedb.com>
jbattiato
approved these changes
Nov 25, 2025
Member
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/19666506912 |
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 25, 2025
Previously we emitted error and logs only for the errors of NotFound category, for the other types the the controller would fail silently without emitting a Kubernetes event. This made troubleshooting difficult, especially when using tools like ArgoCD. This commit ensures that a Warning event and a log is emitted when the ImageCatalog cannot be retrieved for any reason, providing better visibility into configuration errors. Closes #9016 Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Jonathan Battiato <jonathan.battiato@enterprisedb.com> Co-authored-by: Jonathan Battiato <jonathan.battiato@enterprisedb.com> (cherry picked from commit 9a354b8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we emitted error and logs only for the errors of NotFound category, for the other types the the controller would fail silently without emitting a Kubernetes event. This made troubleshooting difficult, especially when using tools like ArgoCD.
This commit ensures that a Warning event and a log is emitted when the ImageCatalog cannot be retrieved for any reason, providing better visibility into configuration errors.
Closes #9016