fix: add SkipNameValidation when creating controller in retry block#9123
Merged
leonardoce merged 2 commits intocloudnative-pg:mainfrom Nov 17, 2025
Merged
fix: add SkipNameValidation when creating controller in retry block#9123leonardoce merged 2 commits intocloudnative-pg:mainfrom
leonardoce merged 2 commits intocloudnative-pg:mainfrom
Conversation
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
Member
|
/test limit=local |
Contributor
|
@armru, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/19271484901 |
Signed-off-by: Mateus Oliveira <66965232+mateusoliveira43@users.noreply.github.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
leonardoce
approved these changes
Nov 17, 2025
armru
approved these changes
Nov 17, 2025
cnpg-bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
…9123) If `runSubCommand` fails after it creates instance-cluster controller, all subsequent runs will fail with `controller with name instance-cluster already exists` error. To fix this, the patch adds `SkipNameValidation` to the controller options for subsequent runs. Also adds error logs every time an error is returned. See: #9159 Signed-off-by: Mateus Oliveira <66965232+mateusoliveira43@users.noreply.github.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit dfd3e3c)
leonardoce
pushed a commit
that referenced
this pull request
Nov 17, 2025
…9123) If `runSubCommand` fails after it creates instance-cluster controller, all subsequent runs will fail with `controller with name instance-cluster already exists` error. To fix this, the patch adds `SkipNameValidation` to the controller options for subsequent runs. Also adds error logs every time an error is returned. See: #9159 Signed-off-by: Mateus Oliveira <66965232+mateusoliveira43@users.noreply.github.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit dfd3e3c)
leonardoce
pushed a commit
that referenced
this pull request
Nov 17, 2025
…9123) If `runSubCommand` fails after it creates instance-cluster controller, all subsequent runs will fail with `controller with name instance-cluster already exists` error. To fix this, the patch adds `SkipNameValidation` to the controller options for subsequent runs. Also adds error logs every time an error is returned. See: #9159 Signed-off-by: Mateus Oliveira <66965232+mateusoliveira43@users.noreply.github.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit dfd3e3c) (cherry picked from commit 4ee77d0)
mnencia
pushed a commit
that referenced
this pull request
Jan 20, 2026
…9123) If `runSubCommand` fails after it creates instance-cluster controller, all subsequent runs will fail with `controller with name instance-cluster already exists` error. To fix this, the patch adds `SkipNameValidation` to the controller options for subsequent runs. Also adds error logs every time an error is returned. See: #9159 Signed-off-by: Mateus Oliveira <66965232+mateusoliveira43@users.noreply.github.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> (cherry picked from commit dfd3e3c) (cherry picked from commit 4ee77d0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
runSubCommandfails after it creates instance-cluster controller, all subsequent runs will fail withcontroller with name instance-cluster already existserror. To fix this, the patch addsSkipNameValidationto the controller options for subsequent runs.Also adds error logs every time an error is returned.
See: #5994