Skip to content

feat: check for empty wal archive on pg_basebackup bootstrap#8895

Merged
mnencia merged 2 commits intomainfrom
dev/check-empty-wal-replica-cluster
Oct 22, 2025
Merged

feat: check for empty wal archive on pg_basebackup bootstrap#8895
mnencia merged 2 commits intomainfrom
dev/check-empty-wal-replica-cluster

Conversation

@mnencia
Copy link
Member

@mnencia mnencia commented Oct 21, 2025

Enable the empty WAL archive check also when a Cluster is initialized using the pg_basebackup bootstrap method.

Closes #8897

@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.25 release-1.26 release-1.27 labels Oct 21, 2025
@github-actions
Copy link
Contributor

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@mnencia
Copy link
Member Author

mnencia commented Oct 21, 2025

/test

@github-actions
Copy link
Contributor

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/18682632440

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 21, 2025
@mnencia mnencia marked this pull request as ready for review October 21, 2025 12:56
@mnencia mnencia requested a review from a team as a code owner October 21, 2025 12:56
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement 🪄 New feature or request labels Oct 21, 2025
@mnencia mnencia force-pushed the dev/check-empty-wal-replica-cluster branch from 8f369c0 to 54018b9 Compare October 21, 2025 13:07
mnencia and others added 2 commits October 21, 2025 22:55
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
@gbartolini gbartolini force-pushed the dev/check-empty-wal-replica-cluster branch from 653cabf to d717e82 Compare October 21, 2025 19:55
@gbartolini
Copy link
Contributor

/test

@github-actions
Copy link
Contributor

@gbartolini, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/18695942536

@mnencia
Copy link
Member Author

mnencia commented Oct 22, 2025

/ok-to-merge Tests are failingdue to a bug in minio setup, the tests regarding the feature are green

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Oct 22, 2025
@mnencia mnencia merged commit 9137570 into main Oct 22, 2025
36 of 37 checks passed
@mnencia mnencia deleted the dev/check-empty-wal-replica-cluster branch October 22, 2025 09:25
cnpg-bot pushed a commit that referenced this pull request Oct 22, 2025
…ootstrap (#8895)

Enable the empty WAL archive check also when a Cluster is initialized
using the` pg_basebackup` bootstrap method, like we already do
with all the other bootstrap methods.

Closes #8897

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 9137570)
cnpg-bot pushed a commit that referenced this pull request Oct 22, 2025
…ootstrap (#8895)

Enable the empty WAL archive check also when a Cluster is initialized
using the` pg_basebackup` bootstrap method, like we already do
with all the other bootstrap methods.

Closes #8897

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 9137570)
cnpg-bot pushed a commit that referenced this pull request Oct 22, 2025
…ootstrap (#8895)

Enable the empty WAL archive check also when a Cluster is initialized
using the` pg_basebackup` bootstrap method, like we already do
with all the other bootstrap methods.

Closes #8897

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
(cherry picked from commit 9137570)
THE-BRAHMA pushed a commit to THE-BRAHMA/cloudnative-pg that referenced this pull request Oct 30, 2025
…ootstrap (cloudnative-pg#8895)

Enable the empty WAL archive check also when a Cluster is initialized
using the` pg_basebackup` bootstrap method, like we already do
with all the other bootstrap methods.

Closes cloudnative-pg#8897

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-requested ◀️ This pull request should be backported to all supported releases enhancement 🪄 New feature or request lgtm This PR has been approved by a maintainer ok to merge 👌 This PR can be merged release-1.25 release-1.26 release-1.27 size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: check empty WAL destination when bootstrap method is pg_basebackup

4 participants