chore: deprecate `monitoring.enablePodMonitor` in Cluster and Pooler by phisco · Pull Request #8753 · cloudnative-pg/cloudnative-pg

phisco · 2025-10-06T08:24:45Z

Mark the enablePodMonitor field as deprecated in both Cluster and Pooler monitoring configuration. This field will be removed in future releases, and users should create PodMonitor resources manually if needed.

The deprecation notice has been added to:

API type definitions (cluster_types.go and pooler_types.go)
Generated CRD manifests for both Clusters and Poolers

Documentation has been updated accordingly.

Closes #8075

github-actions · 2025-10-06T08:24:54Z

❗ By default, the pull request is configured to backport to all release branches.

To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

gbartolini · 2025-10-06T12:28:36Z

I think we should backport this patch to give users more time to update.

gbartolini · 2025-10-06T12:28:54Z

/test

github-actions · 2025-10-06T12:29:06Z

@gbartolini, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/18280849444

phisco · 2025-10-09T07:43:11Z

while working on the helm chart PR, I noticed I missed deprecating a few other related fields, given that this is still in flight I'll update this pr.

gbartolini · 2025-10-09T18:45:31Z

@phisco I have added a draft of documentation. However, could you please add a warning/notice to users that still set the option?

phisco · 2025-10-09T21:16:55Z

@gbartolini, just to be sure, you mean through the validating webhook, right?

gbartolini · 2025-10-10T05:59:10Z

I think a webhook now is fine, as long as when we decomission support for enable pod monitor, we remove the ownership from the cluster and detach the pod monitor resource (unless you have better ideas). In the meantime we will just start telling users to manually configure them. The important thing for us is that it is clear that we won't invest in this feature anymore as it is not our domain.

mnencia · 2025-10-13T14:52:01Z

/test

github-actions · 2025-10-13T14:52:10Z

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/18469731730

Mark the `enablePodMonitor` field as deprecated in both Cluster and Pooler monitoring configuration. This field will be removed in future releases, and users should create PodMonitor resources manually if needed. The deprecation notice has been added to: - API type definitions (cluster_types.go and pooler_types.go) - Generated CRD manifests for both Clusters and Poolers Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

…8753) Mark the `enablePodMonitor` field as deprecated in both `Cluster` and `Pooler` monitoring configuration. This field will be removed in future releases, and users should create `PodMonitor` resources manually if needed. The deprecation notice has been added to: - API type definitions (`cluster_types.go` and `pooler_types.go`) - Generated CRD manifests for both Clusters and Poolers Documentation has been updated accordingly. Closes #8075 Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> (cherry picked from commit 232979c)

rouke-broersma · 2025-10-24T08:44:47Z

I think a webhook now is fine, as long as when we decomission support for enable pod monitor, we remove the ownership from the cluster and detach the pod monitor resource (unless you have better ideas). In the meantime we will just start telling users to manually configure them. The important thing for us is that it is clear that we won't invest in this feature anymore as it is not our domain.

Personally I would much rather that CNPG removes the pod monitor instead of detaching ownership so it becomes clear immediately during testing of the new operator that you missed something important instead of silently continuing to receive metrics for existing resources but having unmanaged podmonitors all of a sudden.

…loudnative-pg#8753) Mark the `enablePodMonitor` field as deprecated in both `Cluster` and `Pooler` monitoring configuration. This field will be removed in future releases, and users should create `PodMonitor` resources manually if needed. The deprecation notice has been added to: - API type definitions (`cluster_types.go` and `pooler_types.go`) - Generated CRD manifests for both Clusters and Poolers Documentation has been updated accordingly. Closes cloudnative-pg#8075 Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>

phisco requested a review from a team as a code owner October 6, 2025 08:24

dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 6, 2025

cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.25 release-1.26 release-1.27 labels Oct 6, 2025

dosubot bot added the chore Intangible work to reduce technical debt label Oct 6, 2025

phisco force-pushed the dev/8075 branch 2 times, most recently from 4f4469f to c80ebc6 Compare October 6, 2025 08:50

phisco requested a review from jsilvela as a code owner October 6, 2025 08:50

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 6, 2025

gbartolini changed the title ~~chore: deprecate spec.monitoring.enablePodMonitor~~ chore: deprecate spec.monitoring.enablePodMonitor Oct 6, 2025

gbartolini changed the title ~~chore: deprecate spec.monitoring.enablePodMonitor~~ chore: deprecate monitoring.enablePodMonitor in Cluster and Pooler Oct 6, 2025

gbartolini force-pushed the dev/8075 branch from c41f48e to 38aee83 Compare October 6, 2025 12:27

gbartolini approved these changes Oct 6, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2025

gbartolini force-pushed the dev/8075 branch from 38aee83 to 12e6c15 Compare October 6, 2025 12:28

cnpg-bot added the ok to merge 👌 This PR can be merged label Oct 6, 2025

phisco requested review from NiccoloFei and litaocdl as code owners October 9, 2025 22:29

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 9, 2025

phisco force-pushed the dev/8075 branch from 1c933c0 to d82f745 Compare October 9, 2025 22:29

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Oct 9, 2025

phisco force-pushed the dev/8075 branch from eac8182 to 12f8c93 Compare October 13, 2025 07:35

armru force-pushed the dev/8075 branch 2 times, most recently from 6c55ce4 to 8215481 Compare October 13, 2025 10:19

armru approved these changes Oct 13, 2025

View reviewed changes

mnencia force-pushed the dev/8075 branch from 8215481 to 1da63dd Compare October 13, 2025 14:51

gbartolini approved these changes Oct 13, 2025

View reviewed changes

phisco and others added 8 commits October 13, 2025 21:03

docs: review

991449f

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

docs: updated

45f1e9c

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

chore: deprecate other monitoring related fields

db03452

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

chore: add warnings for deprecated monitoring fields

a0b6d2e

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

chore: add nolint directives for deprecated monitoring fields

8d363ec

Signed-off-by: Philippe Scorsolini <p.scorsolini@gmail.com>

chore: better webhook messages

c5bf6c1

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

chore: add back +optional to PodMonitorMetricRelabelConfigs

fb43cca

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

gbartolini force-pushed the dev/8075 branch from d9b567f to fb43cca Compare October 13, 2025 19:03

mnencia approved these changes Oct 13, 2025

View reviewed changes

mnencia merged commit 232979c into cloudnative-pg:main Oct 13, 2025
30 of 31 checks passed

github-actions bot mentioned this pull request Oct 13, 2025

Backport failure for pull request 8753 #8843

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: deprecate `monitoring.enablePodMonitor` in Cluster and Pooler#8753

chore: deprecate `monitoring.enablePodMonitor` in Cluster and Pooler#8753
mnencia merged 8 commits intocloudnative-pg:mainfrom
phisco:dev/8075

phisco commented Oct 6, 2025 •

edited by mnencia

Loading

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

gbartolini commented Oct 6, 2025

Uh oh!

gbartolini commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

phisco commented Oct 9, 2025

Uh oh!

gbartolini commented Oct 9, 2025

Uh oh!

phisco commented Oct 9, 2025

Uh oh!

gbartolini commented Oct 10, 2025

Uh oh!

mnencia commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

Uh oh!

rouke-broersma commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

phisco commented Oct 6, 2025 • edited by mnencia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

gbartolini commented Oct 6, 2025

Uh oh!

gbartolini commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

phisco commented Oct 9, 2025

Uh oh!

gbartolini commented Oct 9, 2025

Uh oh!

phisco commented Oct 9, 2025

Uh oh!

gbartolini commented Oct 10, 2025

Uh oh!

mnencia commented Oct 13, 2025

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

Uh oh!

rouke-broersma commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

phisco commented Oct 6, 2025 •

edited by mnencia

Loading