fix(cnpgi,connection): improve retry algorithm#8554
Merged
mnencia merged 1 commit intocloudnative-pg:mainfrom Sep 10, 2025
Merged
fix(cnpgi,connection): improve retry algorithm#8554mnencia merged 1 commit intocloudnative-pg:mainfrom
mnencia merged 1 commit intocloudnative-pg:mainfrom
Conversation
On each execution of the plugin reconciliation loop, the plugin’s connection pool is closed and recreated with the newly detected settings. If a connection request occurs while the pool is being recreated, the request may fail with a "closed pool" error. This patch improves the reconciliation logic to properly detect pool changes and enhances the retry mechanism by introducing an exponential backoff strategy. Fixes: cloudnative-pg#8553 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
gbartolini
approved these changes
Sep 9, 2025
Member
|
/test |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/17587060344 |
armru
approved these changes
Sep 10, 2025
|
We are testing that change in our dev environment. We haven't found any errors related to the closed pool in the last 12 hours. I'll keep you updated later to confirm that this behavior has been fixed by that change. I would like to express my sincere gratitude for your prompt and efficient contribution, @leonardoce. Your assistance in resolving the issue is greatly appreciated. |
mnencia
approved these changes
Sep 10, 2025
Member
|
Thanks @jakubhajek, for the confirmation. I'm going to merge this PR. |
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
On each execution of the plugin reconciliation loop, the plugin’s connection pool is closed and recreated with the newly detected settings. If a connection request occurs while the pool is being recreated, the request may fail with a "closed pool" error. This patch improves the reconciliation logic to properly detect pool changes and enhances the retry mechanism by introducing an exponential backoff strategy. Fixes: #8553 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> (cherry picked from commit efc4192)
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
On each execution of the plugin reconciliation loop, the plugin’s connection pool is closed and recreated with the newly detected settings. If a connection request occurs while the pool is being recreated, the request may fail with a "closed pool" error. This patch improves the reconciliation logic to properly detect pool changes and enhances the retry mechanism by introducing an exponential backoff strategy. Fixes: #8553 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> (cherry picked from commit efc4192)
cnpg-bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
On each execution of the plugin reconciliation loop, the plugin’s connection pool is closed and recreated with the newly detected settings. If a connection request occurs while the pool is being recreated, the request may fail with a "closed pool" error. This patch improves the reconciliation logic to properly detect pool changes and enhances the retry mechanism by introducing an exponential backoff strategy. Fixes: #8553 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> (cherry picked from commit efc4192)
rossigee
pushed a commit
to rossigee/cloudnative-pg
that referenced
this pull request
Oct 2, 2025
On each execution of the plugin reconciliation loop, the plugin’s connection pool is closed and recreated with the newly detected settings. If a connection request occurs while the pool is being recreated, the request may fail with a "closed pool" error. This patch improves the reconciliation logic to properly detect pool changes and enhances the retry mechanism by introducing an exponential backoff strategy. Fixes: cloudnative-pg#8553 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
4 tasks
THE-BRAHMA
pushed a commit
to THE-BRAHMA/cloudnative-pg
that referenced
this pull request
Oct 30, 2025
On each execution of the plugin reconciliation loop, the plugin’s connection pool is closed and recreated with the newly detected settings. If a connection request occurs while the pool is being recreated, the request may fail with a "closed pool" error. This patch improves the reconciliation logic to properly detect pool changes and enhances the retry mechanism by introducing an exponential backoff strategy. Fixes: cloudnative-pg#8553 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com> Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On each execution of the plugin reconciliation loop, the plugin’s connection pool is closed and recreated with the newly detected settings.
If a connection request occurs while the pool is being recreated, the request may fail with a "closed pool" error.
This patch improves the reconciliation logic to properly detect pool changes and enhances the retry mechanism by introducing an exponential backoff strategy.
Fixes: #8553