Skip to content

fix(backup,status): add majorVersion to backups#8464

Merged
gbartolini merged 9 commits intomainfrom
dev/backup-add-major
Sep 12, 2025
Merged

fix(backup,status): add majorVersion to backups#8464
gbartolini merged 9 commits intomainfrom
dev/backup-add-major

Conversation

@armru
Copy link
Member

@armru armru commented Aug 28, 2025 •
edited by gbartolini
Loading

Expose the PostgreSQL major version in the backup status and add a new label cnpg.io/majorVersion to volume snapshots.

This change also fixes a bug during major upgrades, preventing backups from being taken.

Partially closes #7705

@armru armru requested review from a team, NiccoloFei, jsilvela and litaocdl as code owners August 28, 2025 15:30
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Aug 28, 2025
@armru armru force-pushed the dev/backup-add-major branch from f9ec5f6 to 3fcfae0 Compare August 28, 2025 15:30
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. github_actions Pull requests that update GitHub Actions code and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 28, 2025
@armru armru force-pushed the dev/backup-add-major branch 2 times, most recently from a2f6cea to 1935fef Compare August 28, 2025 15:31
@armru armru changed the title Dev/backup add major feat(bacup,status): add `MajorVersion Aug 28, 2025
@armru armru force-pushed the dev/backup-add-major branch from 1935fef to 041be39 Compare August 28, 2025 15:33
@armru armru changed the title feat(bacup,status): add `MajorVersion feat(backup,status): add `MajorVersion Aug 28, 2025
@armru armru changed the title feat(backup,status): add `MajorVersion feat(backup,status): add MajorVersion Aug 28, 2025
@armru armru force-pushed the dev/backup-add-major branch 3 times, most recently from 75470ef to 26c394e Compare August 28, 2025 15:44
@leonardoce leonardoce force-pushed the dev/backup-controller branch 2 times, most recently from eb7beb7 to aff973b Compare August 29, 2025 08:39
Base automatically changed from dev/backup-controller to main August 29, 2025 08:52
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 29, 2025
@armru armru force-pushed the dev/backup-add-major branch from 26c394e to 1633d59 Compare August 29, 2025 10:43
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 29, 2025
@armru armru mentioned this pull request Aug 29, 2025
Merged
@leonardoce leonardoce force-pushed the dev/backup-add-major branch from 448cd7d to d453a8d Compare August 29, 2025 12:37
@mnencia mnencia force-pushed the dev/backup-add-major branch from d453a8d to e69f020 Compare September 3, 2025 14:10
@mnencia
Copy link
Member

mnencia commented Sep 3, 2025

/test

leonardoce and others added 8 commits September 12, 2025 10:48
@leonardoce @gbartolini
chore: nits
5e306b1 
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
@mnencia @gbartolini
fix: podHasLatestMajorImage
c089e5c 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia @gbartolini
chore: generate apidoc
7a50907 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia @gbartolini
fix: primary logic
53e01b5 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia @gbartolini
chore: manage the error like it was a not-found
4e399ec 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia @gbartolini
feat: add a label on snapshots
0feb9dd 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia @gbartolini
docs: add label documentation
2f793db 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@gbartolini
docs: order
5e75152 
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
@gbartolini
Copy link
Contributor

gbartolini commented Sep 12, 2025

/test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2025

@gbartolini, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/17669541636

@gbartolini gbartolini added backport-requested ◀️ This pull request should be backported to all supported releases release-1.25 release-1.26 labels Sep 12, 2025
@gbartolini gbartolini merged commit de99f90 into main Sep 12, 2025
41 checks passed
@gbartolini gbartolini deleted the dev/backup-add-major branch September 12, 2025 11:44
@github-actions github-actions bot mentioned this pull request Sep 12, 2025
Closed
mnencia added a commit that referenced this pull request Sep 12, 2025
@armru @leonardoce
@mnencia @gbartolini
fix(backup,status): add majorVersion to backups (#8464)
5a8e8c0 
Expose the PostgreSQL major version in the backup status and add a new
label `cnpg.io/majorVersion` to volume snapshots.

This change also fixes a bug during major upgrades, preventing backups
from being taken.

Partially closes #7705

---------

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
(cherry picked from commit de99f90)
mnencia added a commit that referenced this pull request Sep 12, 2025
@armru @leonardoce
@mnencia @gbartolini
fix(backup,status): add majorVersion to backups (#8464)
68f8041 
Expose the PostgreSQL major version in the backup status and add a new
label `cnpg.io/majorVersion` to volume snapshots.

This change also fixes a bug during major upgrades, preventing backups
from being taken.

Partially closes #7705

---------

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
(cherry picked from commit de99f90)
mnencia added a commit that referenced this pull request Sep 12, 2025
@armru @leonardoce
@mnencia @gbartolini
fix(backup,status): add majorVersion to backups (#8464)
1db7b14 
Expose the PostgreSQL major version in the backup status and add a new
label `cnpg.io/majorVersion` to volume snapshots.

This change also fixes a bug during major upgrades, preventing backups
from being taken.

Partially closes #7705

---------

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
(cherry picked from commit de99f90)
gbartolini pushed a commit that referenced this pull request Sep 12, 2025
@armru @mnencia
fix(instance,scaleup): prevent use of outdated snapshots during major…
62c6bd0 
… upgrades (#8475)

Avoids a bug where volume snapshot backups from a previous minor version
could be incorrectly reused when scaling up, leading to issues during
major PostgreSQL upgrades.

Depends On #8464  
Closes #7705

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
cnpg-bot pushed a commit that referenced this pull request Sep 12, 2025
@armru @mnencia
fix(instance,scaleup): prevent use of outdated snapshots during major…
8c257f9 
… upgrades (#8475)

Avoids a bug where volume snapshot backups from a previous minor version
could be incorrectly reused when scaling up, leading to issues during
major PostgreSQL upgrades.

Depends On #8464
Closes #7705

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
(cherry picked from commit 62c6bd0)
mnencia added a commit that referenced this pull request Sep 12, 2025
@armru @mnencia
fix(instance,scaleup): prevent use of outdated snapshots during major…
5222351 
… upgrades (#8475)

Avoids a bug where volume snapshot backups from a previous minor version
could be incorrectly reused when scaling up, leading to issues during
major PostgreSQL upgrades.

Depends On #8464
Closes #7705

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
(cherry picked from commit 62c6bd0)
rossigee pushed a commit to rossigee/cloudnative-pg that referenced this pull request Oct 2, 2025
@armru @leonardoce
@mnencia @gbartolini @rossigee
fix(backup,status): add majorVersion to backups (cloudnative-pg#8464)
ce5d454 
Expose the PostgreSQL major version in the backup status and add a new
label `cnpg.io/majorVersion` to volume snapshots.

This change also fixes a bug during major upgrades, preventing backups
from being taken.

Partially closes cloudnative-pg#7705

---------

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
rossigee pushed a commit to rossigee/cloudnative-pg that referenced this pull request Oct 2, 2025
@armru @mnencia @rossigee
fix(instance,scaleup): prevent use of outdated snapshots during major…
4e88ff1 
… upgrades (cloudnative-pg#8475)

Avoids a bug where volume snapshot backups from a previous minor version
could be incorrectly reused when scaling up, leading to issues during
major PostgreSQL upgrades.

Depends On cloudnative-pg#8464  
Closes cloudnative-pg#7705

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
THE-BRAHMA pushed a commit to THE-BRAHMA/cloudnative-pg that referenced this pull request Oct 30, 2025
@armru @leonardoce
@mnencia @gbartolini @THE-BRAHMA
fix(backup,status): add majorVersion to backups (cloudnative-pg#8464)
6d03dd2 
Expose the PostgreSQL major version in the backup status and add a new
label `cnpg.io/majorVersion` to volume snapshots.

This change also fixes a bug during major upgrades, preventing backups
from being taken.

Partially closes cloudnative-pg#7705

---------

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>
THE-BRAHMA pushed a commit to THE-BRAHMA/cloudnative-pg that referenced this pull request Oct 30, 2025
@armru @mnencia @THE-BRAHMA
fix(instance,scaleup): prevent use of outdated snapshots during major…
2b96c51 
… upgrades (cloudnative-pg#8475)

Avoids a bug where volume snapshot backups from a previous minor version
could be incorrectly reused when scaling up, leading to issues during
major PostgreSQL upgrades.

Depends On cloudnative-pg#8464
Closes cloudnative-pg#7705

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnencia mnencia mnencia approved these changes

@gbartolini gbartolini gbartolini approved these changes

@jsilvela jsilvela Awaiting requested review from jsilvela jsilvela is a code owner

@NiccoloFei NiccoloFei Awaiting requested review from NiccoloFei

@litaocdl litaocdl Awaiting requested review from litaocdl

Assignees

No one assigned

Labels

backport-requested ◀️ This pull request should be backported to all supported releases github_actions Pull requests that update GitHub Actions code lgtm This PR has been approved by a maintainer ok to merge 👌 This PR can be merged release-1.26 release-1.27 size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Errors scaling up after an in-place major upgrade when VolumeSnapshots backup are available

6 participants

@armru @mnencia @hh24k @gbartolini @cnpg-bot @leonardoce