Skip to content

feat(rollout): support changing image and PostgreSQL settings simultaneously#8115

Merged
gbartolini merged 7 commits intocloudnative-pg:mainfrom
leonardoce:image-guc
Jul 25, 2025
Merged

feat(rollout): support changing image and PostgreSQL settings simultaneously#8115
gbartolini merged 7 commits intocloudnative-pg:mainfrom
leonardoce:image-guc

Conversation

@leonardoce
Copy link
Contributor

@leonardoce leonardoce commented Jul 23, 2025 •
edited by gbartolini
Loading

Allow updating the container image (including PostgreSQL version or extensions) and PostgreSQL configuration settings in a single operation. The image change will trigger the first rollout, followed by the configuration changes in a subsequent rollout.

Closes: #2530

@cnpg-bot cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.25 release-1.26 labels Jul 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

❗ By default, the pull request is configured to backport to all release branches.

  • To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
  • To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

@leonardoce leonardoce force-pushed the image-guc branch 2 times, most recently from 945c402 to a534912 Compare July 24, 2025 05:33
@leonardoce leonardoce marked this pull request as ready for review July 24, 2025 05:33
@leonardoce leonardoce requested a review from a team as a code owner July 24, 2025 05:33
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 24, 2025
@leonardoce leonardoce changed the title feat: allow changing the image name and the PG settings as the same time feat: allow changing the image name and the PG settings as the same time [wip] Jul 24, 2025
@dosubot dosubot bot added the enhancement 🪄 New feature or request label Jul 24, 2025
@leonardoce
Copy link
Contributor Author

leonardoce commented Jul 24, 2025

/test limit=local

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

@leonardoce, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/16488666735

@cnpg-bot cnpg-bot added the ok to merge 👌 This PR can be merged label Jul 24, 2025
@mnencia mnencia added do not backport This PR must not be backported - it will be in the next minor release and removed backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.25 release-1.26 labels Jul 24, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2025
@mnencia mnencia changed the title feat: allow changing the image name and the PG settings as the same time [wip] feat: allow changing the image name and the PG settings as the same time Jul 24, 2025
@mnencia
Copy link
Member

mnencia commented Jul 24, 2025

/test

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2025

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/16500232246

leonardoce
leonardoce commented Jul 25, 2025
View reviewed changes
leonardoce
leonardoce commented Jul 25, 2025
View reviewed changes
@gbartolini gbartolini requested a review from jsilvela as a code owner July 25, 2025 09:15
leonardoce and others added 6 commits July 25, 2025 12:52
@leonardoce @jbattiato
feat: allow changing the image name and the PG settings as the same time
887afb2 
Closes: cloudnative-pg#2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
@armru @mnencia @jbattiato
wip: review
4a7abb4 
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia @jbattiato
chore: review
b8130a6 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia @leonardoce @jbattiato
chore: apply suggestions from @leonardoce
b5cdc94 
Co-authored-by: Leonardo Cecchi <leonardo.cecchi@gmail.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@mnencia @jbattiato
chore: review
1f18d70 
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
@gbartolini @jbattiato
docs: mention precedence of image change
c14f869 
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
@gbartolini
docs: rephrased
8dd7f32 
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
@gbartolini gbartolini changed the title feat: allow changing the image name and the PG settings as the same time feat(rollout): support changing image and PostgreSQL settings simultaneously Jul 25, 2025
@gbartolini gbartolini merged commit fc7d1e3 into cloudnative-pg:main Jul 25, 2025
32 checks passed
leonardoce added a commit to leonardoce/cloudnative-pg that referenced this pull request Jul 28, 2025
@leonardoce
revert: support changing image and PostgreSQL settings simultaneously (…
a795c2a 
…cloudnative-pg#8115)

This reverts commit fc7d1e3.

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
@dosubot dosubot bot mentioned this pull request Jul 28, 2025
Closed
4 tasks
@gbartolini gbartolini mentioned this pull request Jul 30, 2025
Closed
4 tasks
armru added a commit that referenced this pull request Jul 31, 2025
@armru
feat(rollout): support changing image and PostgreSQL settings simulta…
9cbf01c 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
NiccoloFei pushed a commit that referenced this pull request Aug 1, 2025
@leonardoce @armru
@mnencia @gbartolini @NiccoloFei
feat(rollout): support changing image and PostgreSQL settings simulta…
9a621d4 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
NiccoloFei pushed a commit that referenced this pull request Aug 4, 2025
@leonardoce @armru
@mnencia @gbartolini @NiccoloFei
feat(rollout): support changing image and PostgreSQL settings simulta…
70115db 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
NiccoloFei pushed a commit that referenced this pull request Aug 6, 2025
@leonardoce @armru
@mnencia @gbartolini @NiccoloFei
feat(rollout): support changing image and PostgreSQL settings simulta…
2e3a772 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
NiccoloFei pushed a commit that referenced this pull request Aug 13, 2025
@leonardoce @armru
@mnencia @gbartolini @NiccoloFei
feat(rollout): support changing image and PostgreSQL settings simulta…
dbc2d34 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
NiccoloFei pushed a commit that referenced this pull request Aug 25, 2025
@leonardoce @armru
@mnencia @gbartolini @NiccoloFei
feat(rollout): support changing image and PostgreSQL settings simulta…
fef5dcd 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
@gbartolini gbartolini mentioned this pull request Sep 5, 2025
Merged
NiccoloFei pushed a commit that referenced this pull request Sep 29, 2025
@leonardoce @armru
@mnencia @gbartolini @NiccoloFei
feat(rollout): support changing image and PostgreSQL settings simulta…
7f71fb2 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
NiccoloFei pushed a commit that referenced this pull request Sep 29, 2025
@leonardoce @armru
@mnencia @gbartolini @NiccoloFei
feat(rollout): support changing image and PostgreSQL settings simulta…
d4f4290 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
NiccoloFei pushed a commit that referenced this pull request Sep 29, 2025
@leonardoce @armru
@mnencia @gbartolini @NiccoloFei
feat(rollout): support changing image and PostgreSQL settings simulta…
c2e4c72 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
leonardoce added a commit that referenced this pull request Oct 1, 2025
@leonardoce @armru
@mnencia @gbartolini
feat(rollout): support changing image and PostgreSQL settings simulta…
65e531c 
…neously (#8115)

Allow updating the container image (including PostgreSQL version or
extensions) and PostgreSQL configuration settings in a single operation.
The image change will trigger the first rollout, followed by the
configuration changes in a subsequent rollout.

Closes: #2530

Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com>
Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnencia mnencia mnencia approved these changes

@gbartolini gbartolini gbartolini approved these changes

@jbattiato jbattiato jbattiato approved these changes

@armru armru armru approved these changes

@jsilvela jsilvela Awaiting requested review from jsilvela jsilvela is a code owner

Assignees

No one assigned

Labels

do not backport This PR must not be backported - it will be in the next minor release enhancement 🪄 New feature or request lgtm This PR has been approved by a maintainer ok to merge 👌 This PR can be merged size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: support changing image and PostgreSQL settings simultaneously

6 participants

@leonardoce @mnencia @gbartolini @jbattiato @armru @cnpg-bot