chore(cluster): add support for pprof via `alpha.cnpg.io/enableInstancePprof` annotation by sxd · Pull Request #7876 · cloudnative-pg/cloudnative-pg

sxd · 2025-06-23T13:51:48Z

This change introduces the ability to enable the Go pprof HTTP server in instance pods by setting the alpha.cnpg.io/enableInstancePprof annotation to "true" on a Cluster resource.

When enabled, each instance pod exposes a pprof server on port 6060/TCP, making it possible to collect and analyse profiling data for debugging and performance tuning. The operator automatically manages the rolling update needed to apply or remove the annotation.

Closes #4056

github-actions · 2025-06-23T13:52:01Z

❗ By default, the pull request is configured to backport to all release branches.

To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

sxd · 2025-06-27T19:52:41Z

Closing since it's not the desired implementation

github-actions · 2025-06-27T19:52:49Z

❗ By default, the pull request is configured to backport to all release branches.

To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

github-actions · 2025-07-21T11:44:46Z

❗ By default, the pull request is configured to backport to all release branches.

To stop backporting this pr, remove the label: backport-requested ◀️ or add the label 'do not backport'
To stop backporting this pr to a certain release branch, remove the specific branch label: release-x.y

mnencia · 2025-07-21T11:45:07Z

Reopened as we want to have pprof usable in 1.27.0

github-actions · 2025-09-16T09:00:04Z

@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/17760504825

This helps to debug the instance manager to search for leaks and some other perfomances issues Closes #4056 Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

…cePprof` annotation (#7876) This change introduces the ability to enable the Go pprof HTTP server in instance pods by setting the `alpha.cnpg.io/enableInstancePprof` annotation to "true" on a Cluster resource. When enabled, each instance pod exposes a pprof server on port 6060/TCP, making it possible to collect and analyse profiling data for debugging and performance tuning. The operator automatically manages the rolling update needed to apply or remove the annotation. Closes #4056 Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> (cherry picked from commit 46ed0bd)

…cePprof` annotation (cloudnative-pg#7876) This change introduces the ability to enable the Go pprof HTTP server in instance pods by setting the `alpha.cnpg.io/enableInstancePprof` annotation to "true" on a Cluster resource. When enabled, each instance pod exposes a pprof server on port 6060/TCP, making it possible to collect and analyse profiling data for debugging and performance tuning. The operator automatically manages the rolling update needed to apply or remove the annotation. Closes cloudnative-pg#4056 Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>

…cePprof` annotation (cloudnative-pg#7876) This change introduces the ability to enable the Go pprof HTTP server in instance pods by setting the `alpha.cnpg.io/enableInstancePprof` annotation to "true" on a Cluster resource. When enabled, each instance pod exposes a pprof server on port 6060/TCP, making it possible to collect and analyse profiling data for debugging and performance tuning. The operator automatically manages the rolling update needed to apply or remove the annotation. Closes cloudnative-pg#4056 Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com> Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Co-authored-by: Armando Ruocco <armando.ruocco@enterprisedb.com> Co-authored-by: Niccolò Fei <niccolo.fei@enterprisedb.com> Co-authored-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com> Co-authored-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com> Signed-off-by: theBrahma <office.utpal.brahma@gmail.com>

cnpg-bot added backport-requested ◀️ This pull request should be backported to all supported releases release-1.22 release-1.25 release-1.26 labels Jun 23, 2025

sxd force-pushed the dev/pprof_instance_manager branch 3 times, most recently from 3a4fb3b to b6aedb0 Compare June 26, 2025 13:15

sxd marked this pull request as ready for review June 26, 2025 13:16

sxd requested review from a team, NiccoloFei, jsilvela and litaocdl as code owners June 26, 2025 13:16

dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. chore Intangible work to reduce technical debt labels Jun 26, 2025

sxd force-pushed the dev/pprof_instance_manager branch from b6aedb0 to 6fa1a0a Compare June 26, 2025 13:42

armru force-pushed the dev/pprof_instance_manager branch from 6fa1a0a to 95924fc Compare June 27, 2025 10:52

armru changed the title ~~chore: add pprof server deployment to the instanace manager~~ chore: add pprof server deployment to the instance manager Jun 27, 2025

armru changed the title ~~chore: add pprof server deployment to the instance manager~~ chore: add pprof server deployment to the instance manager Jun 27, 2025

armru force-pushed the dev/pprof_instance_manager branch 5 times, most recently from 9c8e944 to 9707b2d Compare June 27, 2025 12:43

sxd closed this Jun 27, 2025

mnencia reopened this Jul 21, 2025

cnpg-bot added the ok to merge 👌 This PR can be merged label Sep 16, 2025

mnencia approved these changes Sep 16, 2025

View reviewed changes

mnencia force-pushed the dev/pprof_instance_manager branch from cdd0db5 to d506c46 Compare September 16, 2025 12:09

gbartolini approved these changes Sep 16, 2025

View reviewed changes

sxd and others added 11 commits September 16, 2025 16:26

chore: add pprof server deployment to the instanace manager

91a121d

This helps to debug the instance manager to search for leaks and some other perfomances issues Closes #4056 Signed-off-by: Jonathan Gonzalez V. <jonathan.gonzalez@enterprisedb.com>

wip: proposal, annotation approach

9aa9be6

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

chore: lint

23a6043

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

doc: add doc and lint

b0f063e

Signed-off-by: Armando Ruocco <armando.ruocco@enterprisedb.com>

chore: fix linter

c807fc1

Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>

docs: split long lines

ea421ba

Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>

fix: pyroscope service

525b6dc

Signed-off-by: Niccolò Fei <niccolo.fei@enterprisedb.com>

chore: remove unused service

c239e03

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

chore(setup-cluster): make pyroscope idempotent

4a3a30b

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

docs: Update pyroscope instructions

a18bdc7

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

docs: review

00fa7da

Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>

gbartolini force-pushed the dev/pprof_instance_manager branch from b17e8fe to 00fa7da Compare September 16, 2025 14:26

chore: more edits

79b3dea

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

mnencia force-pushed the dev/pprof_instance_manager branch from f40b2c6 to 79b3dea Compare September 16, 2025 14:55

chore: clickable links

7556bc8

Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>

gbartolini changed the title ~~chore: add pprof server deployment to the instance manager~~ feat(cluster): add support for pprof via alpha.cnpg.io/enableInstancePprof annotation Sep 16, 2025

gbartolini changed the title ~~feat(cluster): add support for pprof via alpha.cnpg.io/enableInstancePprof annotation~~ chore(cluster): add support for pprof via alpha.cnpg.io/enableInstancePprof annotation Sep 16, 2025

mnencia merged commit 46ed0bd into main Sep 16, 2025
37 checks passed

mnencia deleted the dev/pprof_instance_manager branch September 16, 2025 15:47

github-actions bot mentioned this pull request Sep 16, 2025

Backport failure for pull request 7876 #8583

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(cluster): add support for pprof via `alpha.cnpg.io/enableInstancePprof` annotation#7876

chore(cluster): add support for pprof via `alpha.cnpg.io/enableInstancePprof` annotation#7876
mnencia merged 13 commits intomainfrom
dev/pprof_instance_manager

sxd commented Jun 23, 2025 •

edited by gbartolini

Loading

Uh oh!

github-actions bot commented Jun 23, 2025

Uh oh!

sxd commented Jun 27, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

mnencia commented Jul 21, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

sxd commented Jun 23, 2025 • edited by gbartolini Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 23, 2025

Uh oh!

sxd commented Jun 27, 2025

Uh oh!

github-actions bot commented Jun 27, 2025

Uh oh!

github-actions bot commented Jul 21, 2025

Uh oh!

mnencia commented Jul 21, 2025

Uh oh!

github-actions bot commented Sep 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sxd commented Jun 23, 2025 •

edited by gbartolini

Loading