feat: add support for configuring tcp_user_timeout on replicas#7036
Merged
gbartolini merged 15 commits intocloudnative-pg:mainfrom Mar 17, 2025
Merged
feat: add support for configuring tcp_user_timeout on replicas#7036gbartolini merged 15 commits intocloudnative-pg:mainfrom
tcp_user_timeout on replicas#7036gbartolini merged 15 commits intocloudnative-pg:mainfrom
Conversation
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
cb89cde to
3a32a1a
Compare
3a32a1a to
ab6f33a
Compare
fbdf3d8 to
ac3940f
Compare
gbartolini
approved these changes
Mar 3, 2025
primary_conninfo
d90ee4c to
46ead76
Compare
ad01e2c to
a1af47a
Compare
a1af47a to
d2be90b
Compare
d2be90b to
b1c9888
Compare
fcanovai
approved these changes
Mar 11, 2025
b1c9888 to
99a96f8
Compare
99a96f8 to
1f878c8
Compare
1f878c8 to
bd13900
Compare
mnencia
approved these changes
Mar 12, 2025
Member
|
/test tl=4 d=main |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/13812514072 |
primary_conninfoThis patch allows the user to customize the `primary_conninfo` GUC of HA replicas. The validating webhook allows the user to configure only the connection parameters that are not automatically set by the operator. Feat: cloudnative-pg#7035 Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
While discussing this patch, we realized that these settings are a property of the execution environment and not of the individual cluster. Because of that, this experiment rework as a new operator configuration parameter. Signed-off-by: Leonardo Cecchi <leonardo.cecchi@enterprisedb.com>
Update the e2e suite to always use iptables. This is usually the default of a k8s cluster, and puts the cluster at risk of not receiving connections due to them ending up in a tcp_syn_retries timeout. This allows us to test `STANDBY_TCP_SYN_RETRIES` behaviour, and verify fringe behaviours in the cluster. Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
Update the webtest version to 1.7.0 Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
Preserve the older configmap when running tests on it, and reinstall it afterwards. Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
Using Expect within an Eventually doesn't retry the Eventually function, but fails immediately. Remove bare Expects and use g.Expect, or return an error to the eventually instead. Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
Signed-off-by: Francesco Canovai <francesco.canovai@enterprisedb.com>
f09f83d to
8758c22
Compare
Member
|
/test tl=4 d=main |
Contributor
|
@mnencia, here's the link to the E2E on CNPG workflow run: https://github.com/cloudnative-pg/cloudnative-pg/actions/runs/13897188841 |
tcp_user_timeout setting for replicas
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
tcp_user_timeout setting for replicastcp_user_timeout on replicas
Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the
STANDBY_TCP_USER_TIMEOUToperator configuration setting, which, if specified, sets thetcp_user_timeoutparameter on all standby instances managed by the operator. The default value is0, which means the system’s default is used.The
tcp_user_timeoutparameter controls how long transmitted data can remain unacknowledged before the TCP connection is forcibly closed. This allows fine-tuning of standby responsiveness to network disruptions.Closes #7119