Adds preserveTransformations to URL Loader#184
Merged
colbyfayock merged 3 commits intomainfrom Aug 28, 2024
Merged
Conversation
ghostdevv
approved these changes
Aug 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
# [@cloudinary-util/url-loader-v5.8.0](https://github.com/cloudinary-community/cloudinary-util/compare/@cloudinary-util/url-loader-v5.7.1...@cloudinary-util/url-loader-v5.8.0) (2024-08-28) ### Features * Adds preserveTransformations to URL Loader ([#184](#184)) ([56e7f79](56e7f79)), closes [#183](#183)
|
🎉 This PR is included in version @cloudinary-util/url-loader-v5.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
colbyfayock
added a commit
to cloudinary-community/next-cloudinary
that referenced
this pull request
Aug 28, 2024
# Description Uses newly exposed logic from URL Loader and Util to clean up duplicate code for preserveTransformations and pollForProcessingImage cloudinary-community/cloudinary-util#184 cloudinary-community/cloudinary-util#187
This was referenced Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
preserveTransformationsis an option currently maintained at the framework level that reads transformations from a Cloudinary URL as the source and applies them, which by default, only uses the public ID from that URL.From what I can tell there's no reason that this needs to be maintained at the framework level and can instead be maintained with the rest of the URL Loader logic.
Simply
preserveTransformationswhen passing asrcas a Cloudinary URL with a version # (required).Issue Ticket Number
Fixes #183
Type of change
Checklist