Skip to content

Throw error if no public ID for video player options#159

Merged
colbyfayock merged 1 commit intobetafrom
beta+vp-public-id
May 23, 2024
Merged

Throw error if no public ID for video player options#159
colbyfayock merged 1 commit intobetafrom
beta+vp-public-id

Conversation

@colbyfayock
Copy link
Collaborator

@colbyfayock colbyfayock commented May 23, 2024

Description

Public ID (or url) is required via the src prop for the video player. To avoid player issues, throw error if not present.

Issue Ticket Number

Fixes #<ISSUE_NUMBER>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@colbyfayock colbyfayock merged commit 973d5fa into beta May 23, 2024
@colbyfayock colbyfayock deleted the beta+vp-public-id branch May 23, 2024 15:41
github-actions bot pushed a commit that referenced this pull request May 23, 2024
# [@cloudinary-util/url-loader-v5.3.0-beta.3](https://github.com/cloudinary-community/cloudinary-util/compare/@cloudinary-util/url-loader-v5.3.0-beta.2...@cloudinary-util/url-loader-v5.3.0-beta.3) (2024-05-23)

### Features

* Throw error if no public ID for video player options ([#159](#159)) ([973d5fa](973d5fa))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant