Skip to content

Conversation

@sethboyles
Copy link
Member

@sethboyles sethboyles commented Mar 14, 2025

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

  • An explanation of the use cases your change solves

  • Links to any other associated PRs

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

@sethboyles sethboyles force-pushed the deployment_scaling_other_fields branch from 42cd1bc to 0a313a1 Compare March 18, 2025 17:42
@sethboyles sethboyles marked this pull request as ready for review March 19, 2025 17:39
Copy link
Contributor

@Samze Samze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few nits

@sethboyles sethboyles merged commit 47446d3 into main Mar 28, 2025
14 of 15 checks passed
ari-wg-gitbot added a commit to cloudfoundry/capi-release that referenced this pull request Mar 28, 2025
Changes in cloud_controller_ng:

- Scale disk, memory, and log rate with deployments
    PR: cloudfoundry/cloud_controller_ng#4264
    Author: Seth Boyles <seth.boyles@broadcom.com>
@moleske moleske deleted the deployment_scaling_other_fields branch March 29, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants