Allow instance IP ordering and filtering#18
Merged
frodenas merged 3 commits intocloudfoundry:masterfrom Feb 9, 2019
psycofdj:filtering_ips
Merged
Allow instance IP ordering and filtering#18frodenas merged 3 commits intocloudfoundry:masterfrom psycofdj:filtering_ips
frodenas merged 3 commits intocloudfoundry:masterfrom
psycofdj:filtering_ips
Conversation
Contributor
Author
|
@frodenas Please can you give me an initial feedback about the approach, implementation and documentation ? I'll remove the |
Contributor
Author
|
@frodenas any news on this matter ? |
1 similar comment
Contributor
Author
|
@frodenas any news on this matter ? |
Contributor
Author
|
Hello @frodenas |
Contributor
|
Thanks @psycofdj and apologies for the super late review. |
gberche-orange
added a commit
to orange-cloudfoundry/node-exporter-boshrelease
that referenced
this pull request
Feb 7, 2024
Would emit (interface, addr, netmask, scope) labels for every network interface See prometheus/node_exporter#2105 This complements current bosh exporter support for a single IP address, see cloudfoundry/bosh_exporter#18
benjaminguttmann-avtq
pushed a commit
to cloudfoundry/node-exporter-boshrelease
that referenced
this pull request
Feb 27, 2024
Would emit (interface, addr, netmask, scope) labels for every network interface See prometheus/node_exporter#2105 This complements current bosh exporter support for a single IP address, see cloudfoundry/bosh_exporter#18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users to choose which IP of the bosh instance to use as target and label as requested in #17
How it works
filter.cidrsthat gives a coma-seperated list ofCIDR.CIDRin the order given by the listfilter.cidrsis0.0.0.0/0which matches any IP. Consequently, the default behavior is unchanged: the first available IP is used.CIDR, the instance is dropped (which provides a way to filter-out instances by their IP)Example:
Given two instances with their IPs
A:172.30.0.3and10.234.244.37B:192.168.0.55With
--filter.cidrs="0.0.0.0/0"(default flag value)172.30.0.3is checked against0.0.0.0/0, match172.30.0.3is used forA192.168.0.55is checked against0.0.0.0/0, match192.168.0.55is used forBWith
--filter.cidrs="10.234.0.0/16,0.0.0.0/0"172.30.0.3is checked against10.234.0.0/16, no match10.234.244.37is checked against10.234.0.0/16, match10.234.244.37is used forA192.168.0.55is checked against10.234.0.0/16, no match192.168.0.55is checked against0.0.0.0/0, match192.168.0.55is used forB