This repository was archived by the owner on Apr 2, 2019. It is now read-only.
Ecmascript 3 denotes 'char' as "future reserved word"#195
Merged
wyuenho merged 2 commits intocloudflarearchive:masterfrom May 19, 2013
ivorbosloper:patch-1
Merged
Ecmascript 3 denotes 'char' as "future reserved word"#195wyuenho merged 2 commits intocloudflarearchive:masterfrom ivorbosloper:patch-1
wyuenho merged 2 commits intocloudflarearchive:masterfrom
ivorbosloper:patch-1
Conversation
Yuicompressor fails to compress this file because 'char' is a "future reserved word". The fix contains equivalent functionality avoiding the bare 'char' word. Ecmascript 5 dropped this reserved word, but supporting Ecmascript 3 is just a one line change. See Ecmascript 3 spec, section 7.5.3: http://www.ecma-international.org/publications/files/ECMA-ST-ARCH/ECMA-262,%203rd%20edition,%20December%201999.pdf
Contributor
|
Thanks. Can you please change the ' to "? I'll merge as soon as you are ready. |
Contributor
Author
|
What do you mean? I'm still learning git and github. Should I create a pull request into another branch? |
Contributor
|
No just change the ' to ", commit and push. The changes will show up immediately here. |
Contributor
|
Thank you! |
Contributor
Author
|
Thanks for backgrid, works great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yuicompressor fails to compress this file because 'char' is a "future reserved word". The fix contains equivalent functionality avoiding the bare 'char' word.
Ecmascript 5 dropped this reserved word, but supporting Ecmascript 3 is just a one line change.
See Ecmascript 3 spec, section 7.5.3: http://www.ecma-international.org/publications/files/ECMA-ST-ARCH/ECMA-262,%203rd%20edition,%20December%201999.pdf