This repository was archived by the owner on Apr 2, 2019. It is now read-only.
exitEditMode getting called twice on move command#177
Merged
wyuenho merged 1 commit intocloudflarearchive:masterfrom May 15, 2013
Merged
exitEditMode getting called twice on move command#177wyuenho merged 1 commit intocloudflarearchive:masterfrom
wyuenho merged 1 commit intocloudflarearchive:masterfrom
Conversation
…d editor before enterEditMode of new editor to keep exitEditMode from being called twice
|
I was about to post the same bug issue as it was replicable in the first example on the backgridjs.com home page, but gbedardsice has this explained more succinctly than I would. The 1st call to |
Contributor
|
Thanks for reporting this. Free feel to send me a PR. |
Contributor
Author
|
Oops, I always forget this. |
wyuenho
added a commit
that referenced
this pull request
May 15, 2013
exitEditMode no longer gets called on move command
Contributor
|
Thank you. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using move commands (tab, arrows, etc.), the
exitEditModemethod of the editor is being called twice. You can see the error here by simply using a move command.The reason is, here, when you call
enterEditMode, thepostRendermethod of the new cell editor callsfocuson the new editor element, which results in ablurevent on the old editor. ThesaveOrCancelmethod is then called again on the old editor, and then triggers thebackgrid:editedevent a second time.You can resolve this simply by moving this line before the
ifblock, to make sure that the old editor is actually removed before entering in the new editor.