This repository was archived by the owner on Apr 2, 2019. It is now read-only.
Backgrid.Cell's remove passes wrong context to currentEditor?#169
Merged
wyuenho merged 2 commits intocloudflarearchive:masterfrom May 10, 2013
Merged
Backgrid.Cell's remove passes wrong context to currentEditor?#169wyuenho merged 2 commits intocloudflarearchive:masterfrom
wyuenho merged 2 commits intocloudflarearchive:masterfrom
Conversation
wyuenho
added a commit
that referenced
this pull request
May 10, 2013
Pass the right context to the currentEditor.remove
Contributor
|
Thanks! |
Contributor
Author
|
You're welcome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, when calling the
removemethod on thecurrentEditor, shouldn't the context bethis.currentEditor, or even just callthis.currentEditor.remove()?