Skip to content

zconf.h is generated by configure; it should not be in git.#16

Merged
vkrasnov merged 1 commit intocloudflare:gcc.amd64from
kentonv:gcc.amd64
Apr 3, 2019
Merged

zconf.h is generated by configure; it should not be in git.#16
vkrasnov merged 1 commit intocloudflare:gcc.amd64from
kentonv:gcc.amd64

Conversation

@kentonv
Copy link
Copy Markdown
Member

@kentonv kentonv commented Apr 2, 2019

configure mostly generates this file by copying from zconf.h.in.

configure mostly generates this file by copying from zconf.h.in.
@kentonv
Copy link
Copy Markdown
Member Author

kentonv commented Apr 2, 2019

Note that without this change, running configure will modify this file and those modifications are easy to accidentally commit, which is what #14 was attempting to fix. Also the repo will become dirty which is especially annoying when it's used as a submodule.

@kentonv
Copy link
Copy Markdown
Member Author

kentonv commented Apr 2, 2019

@kornelski Will this break the MSVC build? I have to confess I'm pretty confused about how this is supposed to work.

@kornelski
Copy link
Copy Markdown

cmake build will use zconf.h.cmakein, so it should be fine.

In the Rust sys wrapper I assume the file is there, but it won't be too hard to re-generate it.

@vkrasnov vkrasnov merged commit af9ef2e into cloudflare:gcc.amd64 Apr 3, 2019
fhanau pushed a commit to fhanau/zlib that referenced this pull request Feb 27, 2023
Update the explainer to use WHATWG streams
fhanau pushed a commit to fhanau/zlib that referenced this pull request Feb 27, 2023
Update the specification to explicitly list supported formats, and to
clarify exactly what conditions are considered errors for each format.

Also link some promise-related terms to the Web IDL standard, and
fix the references to the "format" owned by CompressionStream and
DecompressionStream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants