Conversation
|
Fancy describing in more details (in the commit messages) what the patches are actually doing? And how to test the correctness? |
|
It changes the hash and longest match functions to always match at least 4 bytes, instead the 3 the spec allows. It allows for faster and more effective compression because there are less hash collisions, and false matches are discarded faster. |
|
Cool. Can you squeeze the commits into a single commit and add the explanation to the commit message? (unless there is a reason to keep it as four separate commits, but if that's the case, please explain) |
…ast 4 bytes, instead the 3 the spec allows. It allows for faster and more effective compression because there are less hash collisions, and false matches are discarded faster. In theory it could lead to worse compression in some cases, but for the most common files there is an improvement for all levels both in speed and in compression ratio.
There was a problem hiding this comment.
What's the reasoning behind moving *(uInt*)match != scan_start test here?
There was a problem hiding this comment.
You want to resolve a false positive as soon as possible.
|
Looks good, feel free to merge it. |
|
Please squash these small commits into a single one with reasonably verbose commit log, just as @majek suggested. |
It changes the hash and longest match functions to always match at least 4 bytes, instead the 3 the spec allows. It allows for faster and more effective compression because there are less hash collisions, and false matches are discarded faster. In theory it could lead to worse compression in some cases, but for the most common files there is an improvement for all levels both in speed and in compression ratio.
* Add CSS * Add respec-config.js * Add respec-w3c-common.js * Update index.html
First version of CompressionStreams Spec
No description provided.