Skip to content

Remove "Cloudchamber" from user facing error messages#9628

Merged
CarmenPopoviciu merged 2 commits intocloudflare:mainfrom
gpanders:push-wrounopkysmr
Jun 17, 2025
Merged

Remove "Cloudchamber" from user facing error messages#9628
CarmenPopoviciu merged 2 commits intocloudflare:mainfrom
gpanders:push-wrounopkysmr

Conversation

@gpanders
Copy link
Member

@gpanders gpanders commented Jun 17, 2025

This error message can be displayed when using "containers" subcommands, and most users won't know what "Cloudchamber" is (or need to know), so we shouldn't include this in the error message.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: simple change to user facing error message
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: simple change to user facing error message
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: simple change to user facing error message
  • Wrangler V3 Backport

@gpanders gpanders requested review from a team as code owners June 17, 2025 14:00
@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2025

🦋 Changeset detected

Latest commit: 4ebe08d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 17, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9628

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9628

miniflare

npm i https://pkg.pr.new/miniflare@9628

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9628

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9628

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9628

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9628

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9628

wrangler

npm i https://pkg.pr.new/wrangler@9628

commit: 4ebe08d

@CarmenPopoviciu
Copy link
Contributor

@gpanders LGTM! Can you pls add a patch changeset, since this is user facing? 🙏

@gpanders gpanders force-pushed the push-wrounopkysmr branch from ecf8e38 to dc73d9c Compare June 17, 2025 15:08
@gpanders
Copy link
Member Author

@gpanders LGTM! Can you pls add a patch changeset, since this is user facing? 🙏

Sure thing, done!

This error message can be displayed when using "containers" subcommands,
and most users won't know what "Cloudchamber" is (or need to know), so
we shouldn't include this in the error message.
@gpanders gpanders force-pushed the push-wrounopkysmr branch from dc73d9c to b82fc99 Compare June 17, 2025 15:09
@CarmenPopoviciu
Copy link
Contributor

@gpanders fantastic! thank you. I'll take care of CI and backport PR and merge when everything is 🍏

@CarmenPopoviciu CarmenPopoviciu merged commit 92f12f4 into cloudflare:main Jun 17, 2025
32 of 34 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 17, 2025
CarmenPopoviciu added a commit that referenced this pull request Jun 17, 2025
…sages (#9631)

* Remove "Cloudchamber" from user facing error messages

* Update packages/wrangler/src/cloudchamber/common.ts
@gpanders gpanders deleted the push-wrounopkysmr branch June 17, 2025 16:31
jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 18, 2025
…seba/containers_scope

* 'main' of ssh://github.com/cloudflare/workers-sdk: (31 commits)
  Refactor preview mode and ensure compatibility with Vite 7 (cloudflare#9647)
  Block requests vulnerable to opennext vulnerability (cloudflare#9635)
  Add test for cloudchamber buildAndMaybePush (cloudflare#9638)
  chore: remove redundant binding guide superseded by internal docs (cloudflare#9648)
  add changeset to trigger release of workers/pages projects (cloudflare#9649)
  Add @handler to Python templates. (cloudflare#9305)
  Migrate from unbuild to obuild (cloudflare#9243)
  Version Packages (cloudflare#9650)
  fix changeset (cloudflare#9651)
  containers: Default scheduling policy should be the default (cloudflare#9621)
  Rename Mixed Mode to remote proxy/remote bindings depending on context (cloudflare#9586)
  Version Packages (cloudflare#9632)
  Correctly mock out getDockerImageDigest for testing buildAndMaybePush (cloudflare#9636)
  [C3] Bump create-remix from 2.16.6 to 2.16.8 in /packages/create-cloudflare/src/frameworks (cloudflare#9525)
  Remove "Cloudchamber" from user facing error messages (cloudflare#9628)
  sync local containers with latest workerd (cloudflare#9576)
  Bump the workerd-and-workers-types group with 2 updates (cloudflare#9591)
  [C3] Bump gatsby from 5.14.3 to 5.14.4 in /packages/create-cloudflare/src/frameworks (cloudflare#9524)
  [C3] Bump create-react-router from 7.6.1 to 7.6.2 in /packages/create-cloudflare/src/frameworks (cloudflare#9526)
  [C3] Bump create-docusaurus from 3.8.0 to 3.8.1 in /packages/create-cloudflare/src/frameworks (cloudflare#9527)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants