fix: start transferred MessagePort in fetch-sync worker#9198
fix: start transferred MessagePort in fetch-sync worker#9198petebacondarwin merged 2 commits intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 326424d The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
petebacondarwin
left a comment
There was a problem hiding this comment.
Cool. Thanks for adding this.
In Node.js is appears that this is unnecessary as it is implied by attaching a message listener.
But I can see that is where Node.js diverges from the Web standard API.
I'll add a changeset for good measure. Since this has no effect on Node.js and we don't officially support Bun, I don't see any value in adding an extra test for this functionality.
|
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-wrangler-9198Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-cloudflare-workers-bindings-extension-9198 -O ./cloudflare-workers-bindings-extension.0.0.0-v58887391e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v58887391e.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-create-cloudflare-9198 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-cloudflare-kv-asset-handler-9198
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-miniflare-9198
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-cloudflare-pages-shared-9198
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-cloudflare-unenv-preset-9198
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-cloudflare-vite-plugin-9198
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-cloudflare-vitest-pool-workers-9198
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-cloudflare-workers-editor-shared-9198
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-cloudflare-workers-shared-9198
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14967789028/npm-package-cloudflare-workflows-shared-9198Note that these links will no longer work once the GitHub Actions artifact expires. |
This was causing running Miniflare in Bun tests to hang indefinitely.
|
Congratulations @kylecarbs, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmaky49q457540dl4b0tytov6 This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
… worker (#9211) * fix: start transferred MessagePort in fetch-sync worker This was causing running Miniflare in Bun tests to hang indefinitely. * add changeset --------- Co-authored-by: Kyle Carberry <kyle@carberry.com>
This was causing running Miniflare in Bun tests to hang indefinitely.
Fixes oven-sh/bun#16240