Continue `createCommand` migration with ✨AI✨ by penalosa · Pull Request #8966 · cloudflare/workers-sdk

penalosa · 2025-04-15T23:27:27Z

This PR continues the createCommand migration for several new command families:

hyperdrive (which is GA: https://blog.cloudflare.com/making-full-stack-easier-d1-ga-hyperdrive-queues/)
vectorize (which is GA, so I've removed the beta labelling: https://developers.cloudflare.com/vectorize/)
init
delete
triggers
queues
d1
pages
ai
mtls-certificate

Halway through the migration I realised that this would be the perfect test case for something like Claude Code (pretty simple refactoring), and so tested out Claude code for hyperdrive, vectorize, d1, ai, and pages. It did surprisingly well! It halway blew up when doing pages, because more of that change was novel, I guess?

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because: this should pass all existing tests
Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s):
- Documentation not necessary because: internal refactor
Wrangler V3 Backport
- TODO (before merge)
- Wrangler PR:
- Not necessary because: no functionality change

changeset-bot · 2025-04-15T23:27:31Z

🦋 Changeset detected

Latest commit: 59c5886

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-04-16T10:25:49Z

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/create-command might be a good starting point.

github-actions · 2025-04-16T10:28:08Z

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-wrangler-8966

Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-cloudflare-workers-bindings-extension-8966 -O ./cloudflare-workers-bindings-extension.0.0.0-v454b7082c.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v454b7082c.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-create-cloudflare-8966 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-cloudflare-kv-asset-handler-8966

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-miniflare-8966

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-cloudflare-pages-shared-8966

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-cloudflare-unenv-preset-8966

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-cloudflare-vite-plugin-8966

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-cloudflare-vitest-pool-workers-8966

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-cloudflare-workers-editor-shared-8966

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-cloudflare-workers-shared-8966

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14616902982/npm-package-cloudflare-workflows-shared-8966

Note that these links will no longer work once the GitHub Actions artifact expires.

irvinebroque · 2025-04-22T05:12:25Z

👏

petebacondarwin

Nice work Claude! Since it is such a big mechanical PR, we should have just got an AI to review if for us 😜 .

Fun to backport this one...

petebacondarwin · 2025-04-22T09:12:08Z

packages/wrangler/src/__tests__/d1/d1.test.ts

With createCommand, do we no longer get useful error messages saying what was wrong with the input?

We do, but this (and a few other similar places), shouldn't have been errors. This is the output from running d1 migrations, which now just shows the help text. Previously it also showed an error because you hadn't specified a subcommand list/create/apply, which isn't how other commands work

petebacondarwin · 2025-04-22T09:14:26Z

packages/wrangler/src/__tests__/queues.test.ts

Is this test case no longer supported?

This case was never hit, as far as I can tell, since the API never returned that error. I tested on an account without queues enabled, and this message wasn't displayed

petebacondarwin · 2025-04-22T09:15:08Z

packages/wrangler/src/__tests__/vectorize/vectorize.test.ts

Do we still support the --depreacted-v1 flag?

We do, but I've removed the vectorize GA banner that was printed at the end of all commands as an epilogue. Vectorize has been GA for a while, and no other GA commands follow this kind of pattern.

petebacondarwin · 2025-04-22T09:16:15Z

packages/wrangler/src/__tests__/vectorize/vectorize.test.ts

Is this a shortcoming in the createCommand definition options, that we can't say this is an array of numbers?

I think it's a bug in yargs, where if you pass array: true it's not reflected in the help text

packages/wrangler/src/core/register-yargs-command.ts

petebacondarwin · 2025-04-22T09:25:41Z

packages/wrangler/src/d1/execute.ts

Feels like this should be the default for all commands?

It should be. There was one command that used an argument called json for a different purpose, but we changed that in v4, so we should be able to make this printBanner option the default now. I can make that change in this PR?

Actually, that seems like it should be done in a followup

petebacondarwin · 2025-04-22T09:26:44Z

packages/wrangler/src/d1/execute.ts

TODO (not in this PR): consolidate all the JSON logging aspects across the code base.

petebacondarwin · 2025-04-22T09:30:11Z

packages/wrangler/src/d1/export.ts

FUTURE: we should build this into the createCommand mechanism, so it doesn't need to be worked around in individual options/commands.

packages/wrangler/src/d1/insights.ts

packages/wrangler/src/pipelines/cli/create.ts

* wrangler init * wrangler delete * wrangler triggers * halfway through wrangler queues * complete queues migration * wrangler d1 * wrangler ai * hyperdrive & vectorize * pages * Fix AI code * Create thirty-apples-invite.md * more ai fixups * mtls-certificate * wrangler build * wrangler pipelines * wrangler dispatch-namespace * fix check * fix tests * cleanup * address comments * fix lint

workers-devprod added this to workers-sdk Apr 15, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Apr 15, 2025

penalosa changed the title ~~Continue createCommand migration~~ Continue createCommand migration with ✨AI✨ Apr 15, 2025

penalosa marked this pull request as ready for review April 16, 2025 14:07

penalosa requested review from a team as code owners April 16, 2025 14:07

petebacondarwin approved these changes Apr 22, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 22, 2025

penalosa added the e2e Run wrangler + vite-plugin e2e tests on a PR label Apr 22, 2025

penalosa force-pushed the penalosa/create-command branch from caca69f to a0971d5 Compare April 22, 2025 11:39

penalosa and others added 15 commits April 23, 2025 12:22

wrangler init

fd0b02a

wrangler delete

c62b307

wrangler triggers

4f6825b

halfway through wrangler queues

b66adf2

complete queues migration

85f038c

wrangler d1

9c4a364

wrangler ai

f1c7f3e

hyperdrive & vectorize

f00c99d

pages

6a596ba

Fix AI code

e7815b5

Create thirty-apples-invite.md

ca4218c

more ai fixups

0ea06d3

mtls-certificate

e4f67fa

wrangler build

a627742

wrangler pipelines

fea29d2

penalosa added 6 commits April 23, 2025 12:22

wrangler dispatch-namespace

acc42a8

fix check

54c444a

fix tests

3d9e293

cleanup

14f29cb

address comments

6d77d16

fix lint

59c5886

penalosa force-pushed the penalosa/create-command branch from 40cd2db to 59c5886 Compare April 23, 2025 11:22

penalosa merged commit 234afae into main Apr 23, 2025
17 of 18 checks passed

penalosa deleted the penalosa/create-command branch April 23, 2025 13:47

github-project-automation bot moved this from Approved to Done in workers-sdk Apr 23, 2025

workers-devprod mentioned this pull request Apr 23, 2025

Version Packages #9034

Merged

penalosa mentioned this pull request May 22, 2025

feat(wrangler): add support for FedRAMP High compliance region #9321

Merged

12 tasks

Conversation

penalosa commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

github-actions bot commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

irvinebroque commented Apr 22, 2025

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

penalosa Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

penalosa commented Apr 15, 2025 •

edited

Loading

changeset-bot bot commented Apr 15, 2025 •

edited

Loading

github-actions bot commented Apr 16, 2025 •

edited

Loading

penalosa Apr 22, 2025 •

edited

Loading