Skip to content

Move local analytics engine from Wrangler to Miniflare#8935

Merged
penalosa merged 4 commits intomainfrom
penalosa/analytics-engine-local-dev
Apr 22, 2025
Merged

Move local analytics engine from Wrangler to Miniflare#8935
penalosa merged 4 commits intomainfrom
penalosa/analytics-engine-local-dev

Conversation

@penalosa
Copy link
Contributor

@penalosa penalosa commented Apr 14, 2025

Fixes https://jira.cfdata.org/browse/DEVX-1790 and #8348

Migrate the no-op local support for Analytics Engine Dataset bindings from Wrangler to Miniflare. This should mean that both Vite & Vitest can take advantage.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing e2e tests—this is a refactor
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactor
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: refactor with no user facing change for wrangler

@penalosa penalosa requested review from a team as code owners April 14, 2025 14:44
@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2025

🦋 Changeset detected

Latest commit: da78575

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
miniflare Patch
wrangler Patch
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-wrangler-8935
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-cloudflare-workers-bindings-extension-8935 -O ./cloudflare-workers-bindings-extension.0.0.0-v44341147f.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v44341147f.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-create-cloudflare-8935 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-cloudflare-kv-asset-handler-8935

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-miniflare-8935

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-cloudflare-pages-shared-8935

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-cloudflare-unenv-preset-8935

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-cloudflare-vite-plugin-8935

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-cloudflare-vitest-pool-workers-8935

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-cloudflare-workers-editor-shared-8935

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-cloudflare-workers-shared-8935

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14448876346/npm-package-cloudflare-workflows-shared-8935

Note that these links will no longer work once the GitHub Actions artifact expires.

@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/analytics-engine-local-dev might be a good starting point.

@penalosa penalosa added the e2e Run wrangler + vite-plugin e2e tests on a PR label Apr 14, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 15, 2025
@penalosa penalosa merged commit 41f095b into main Apr 22, 2025
44 of 53 checks passed
@penalosa penalosa deleted the penalosa/analytics-engine-local-dev branch April 22, 2025 08:34
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 22, 2025
@lrapoport-cf lrapoport-cf mentioned this pull request Apr 22, 2025
12 tasks
IRCody pushed a commit that referenced this pull request Apr 23, 2025
* Move local analytics engine from Wrangler to Miniflare

* fixup

* Move local analytics engine from Wrangler to Miniflare

* Create tough-dodos-guess.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run wrangler + vite-plugin e2e tests on a PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants