Remove express-based dev registry#7706
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b5afb44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-wrangler-7706You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7706/npm-package-wrangler-7706Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-wrangler-7706 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workers-bindings-extension-7706 -O ./cloudflare-workers-bindings-extension.0.0.0-v718494066.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v718494066.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-create-cloudflare-7706 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-kv-asset-handler-7706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-miniflare-7706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-pages-shared-7706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-unenv-preset-7706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-vitest-pool-workers-7706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workers-editor-shared-7706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workers-shared-7706npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12701538177/npm-package-cloudflare-workflows-shared-7706Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Skye-31
reviewed
Jan 9, 2025
Contributor
There was a problem hiding this comment.
if only this was #4633 😅 for a second I thought that was finally implemented
edmundhung
approved these changes
Jan 9, 2025
c1fc48b to
ac72510
Compare
ac72510 to
b5afb44
Compare
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After turning the file based registry on by default in #7081, usage of the legacy registry has been near 0 (internal metrics). We've also had no recent bug reports related to the file based registry. As such, this PR removes the server based registry implementation.
Additionally, I did some deduping of dependencies (we previously had undici 5.28.4 & 5.28.2 included in the Wrangler bundle).
The result of both of the above is that Wrangler's bundle size is now just 4.4MB, down from the current 7.07MB 🎉