Skip to content

Default --x-registry to on#7081

Merged
penalosa merged 8 commits into
mainfrom
penalosa/default-x-registry
Nov 16, 2024
Merged

Default --x-registry to on#7081
penalosa merged 8 commits into
mainfrom
penalosa/default-x-registry

Conversation

@penalosa

@penalosa penalosa commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

Fixes #6955

Use the file based registry by default. It can still be disabled by setting --x-registry=false when running wrangler dev


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: existing tests should continue to pass
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: experimental flag

@penalosa penalosa requested a review from a team as a code owner October 24, 2024 08:15
@changeset-bot

changeset-bot Bot commented Oct 24, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6288866

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@penalosa penalosa changed the title Default --x-registry to on Default --x-registry to on Oct 24, 2024
@penalosa penalosa added the ci:e2e Run wrangler + vite-plugin E2E tests on a pull request label Oct 24, 2024
@github-actions

github-actions Bot commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-wrangler-7081

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7081/npm-package-wrangler-7081

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-wrangler-7081 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-create-cloudflare-7081 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-cloudflare-kv-asset-handler-7081
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-miniflare-7081
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-cloudflare-pages-shared-7081
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-cloudflare-vitest-pool-workers-7081
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-cloudflare-workers-editor-shared-7081
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-cloudflare-workers-shared-7081
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11864798343/npm-package-cloudflare-workflows-shared-7081

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.87.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa force-pushed the penalosa/default-x-registry branch from e953ef8 to 3c88b01 Compare November 11, 2024 17:20

@andyjessop andyjessop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@penalosa penalosa force-pushed the penalosa/default-x-registry branch from a5f36d0 to d414858 Compare November 15, 2024 22:39
@penalosa penalosa force-pushed the penalosa/default-x-registry branch from d414858 to 36da33e Compare November 15, 2024 22:43
@penalosa penalosa merged commit b4a0e74 into main Nov 16, 2024
@penalosa penalosa deleted the penalosa/default-x-registry branch November 16, 2024 00:34
emily-shen pushed a commit that referenced this pull request Nov 18, 2024
@penalosa penalosa mentioned this pull request Jan 8, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:e2e Run wrangler + vite-plugin E2E tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 BUG: Failed to register worker in local service registry TypeError: fetch failed

2 participants