Pbd/revert-project-root-refactoring#7446
Merged
petebacondarwin merged 5 commits intomainfrom Dec 5, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 425d1ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6debc6d to
425d1ee
Compare
9 tasks
Contributor
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-wrangler-7446You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7446/npm-package-wrangler-7446Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-wrangler-7446 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-create-cloudflare-7446 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-cloudflare-kv-asset-handler-7446npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-miniflare-7446npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-cloudflare-pages-shared-7446npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-cloudflare-vitest-pool-workers-7446npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-cloudflare-workers-editor-shared-7446npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-cloudflare-workers-shared-7446npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12169900626/npm-package-cloudflare-workflows-shared-7446Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
425d1ee to
7725249
Compare
penalosa
approved these changes
Dec 5, 2024
Merged
penalosa
pushed a commit
that referenced
this pull request
Jan 10, 2025
* fix up import-npm package lock * Revert "refactor: remove missed redundant computation of `projectRoot` (#7421)" This reverts commit bea6558. * Revert "refactor: move projectRoot computation to config validation (#7415)" This reverts commit 4f1a46e. * Do not watch workflow tests in `test:ci` jobs * add e2e test to prevent tmp directory regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7440
Fix a regression introduced in #7415 with the tmp dir location for Pages projects
by reverting those changes.