Conversation
🦋 Changeset detectedLatest commit: a6c0a38 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-wrangler-7229You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7229/npm-package-wrangler-7229Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-wrangler-7229 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-create-cloudflare-7229 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-cloudflare-kv-asset-handler-7229npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-miniflare-7229npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-cloudflare-pages-shared-7229npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-cloudflare-vitest-pool-workers-7229npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-cloudflare-workers-editor-shared-7229npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-cloudflare-workers-shared-7229npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12241191766/npm-package-cloudflare-workflows-shared-7229Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
f3bcfb7 to
649cc88
Compare
Love that this comes up when you run apply without an app in wrangler.toml. I think"Deploy a container application deploy changes to your application" is a little confusing though. What's the white part vs the orange part? Maybe drop the white part? |
Small bug when running the default app then modifying its instance count |
|
Not a blocker: I kind of want a "cloudchamber status" code that can tell me what the status of the apps are in my wrangler.toml and if they're up now/what the diff would be. |
|
I logged out of my account and then ran "cloudchamber apply" on a different account, but the diff it was giving me was from my old account 
This should be fresh per account login right? (happy to be challenged on this) Edit: oh wait... "cloudchamber list" showed the other account, so maybe logout/picking an account didn't work like I expected. Hmmm |
|
Is there a way to unset tier? Should there be? |
|
My dream in using this is to be able to somehow output a wrangler.toml configuration with every possible attribute that I might be able to set and have it add comments for what the possible options are. Docs could do this too, but I don't want to have to find them. If you hooked up the plumbing, I could provide the template for this. Not sure what the command would be to do it though "wrangler cloudchamber init --verbose" or something? Maybe linking to the docs for "wrangler apply" from the "-h" command could be generally useful for describing attrs/showing a verbose toml config? |
|
--json doesn't seem to do anything (at least not on noops or errors) EDIT: When I got the "name" error above, it didn't work, but in some other case it returned json. Unclear when |
|
Overall, LOVE the overall feel and the workflow, but left some commends - some of which are brainstormy/not blockers. |
|
I've now gotten into a state where I've made a bunch of apps via the CLI and I can't delete them via the CLI because they're app-driven, so even if I remove the deployments they'll come back to life (I think?). We'll probably need either a "cloudchamber destroy" method that reads from the toml and reverts it all, and/or application CRUD from the CLI. Or maybe some special config to remove an application on next "apply" - thoughts? |
there should definitely be a way to skip defaults for sure |
9550737 to
ba38d17
Compare
|
Small bug, when I apply with --json and this config over and over, it auto-applies the config, but then it seems to not actually take, because on the next apply it says Im going to change tier again. |
|
@gabivlj Is this ready for review? |
Yes. This is up for review. Command designed for heavy Cloudchamber-only users mainly. My main worry to discuss with the wrangler folks here is the diff dependency we are introducing to detect line changes, we can discuss if we can have another method of detecting these line changes. I also understand that we are moving from TOML to JSON in some cases and this command will need to do that instead of TOML rendering. |
be87569 to
21b343b
Compare
container app changes This command is able to take the [[container-app]] configurations, and deploy them to Cloudchamber. To render the differences, we are basing off from https://www.npmjs.com/package/diff?activeTab=readme but transformed to TS and without adding a 600kb bundle size. The command is designed to be CI friendly. In the tests there is some example command renders from different kind of configurations. One of the biggest TODOs here is proper error rendering. We hope to improve that overtime, and pinpoint to the user in the wrangler.toml what went wrong.
penalosa
left a comment
There was a problem hiding this comment.
Approved from the Wrangler side pending dropping the diff dependency (which I think you've done?) and copying the config type into the config validation file
8b25786 to
a6c0a38
Compare
…7229) container app changes This command is able to take the [[container-app]] configurations, and deploy them to Cloudchamber. To render the differences, we are basing off from https://www.npmjs.com/package/diff?activeTab=readme but transformed to TS and without adding a 600kb bundle size. The command is designed to be CI friendly. In the tests there is some example command renders from different kind of configurations. One of the biggest TODOs here is proper error rendering. We hope to improve that overtime, and pinpoint to the user in the wrangler.toml what went wrong.
container app changes
This command is able to take the [[container-app]] configurations, and deploy them to Cloudchamber.
To render the differences, we are introducing a new dependency with "diff". This was already included in the pnpm lock, however we could consider not rolling out a new dependency into wrangler unless absolutely necessary.
The command is designed to be CI friendly. In the tests there is some example command renders from different kind of configurations.
Fixes #[insert GH or internal issue link(s)].
Describe your change...