Add more helpful error messages when validating compatibility date#7002
Add more helpful error messages when validating compatibility date#7002CarmenPopoviciu merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d25e501 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-wrangler-7002You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7002/npm-package-wrangler-7002Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-wrangler-7002 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-create-cloudflare-7002 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-cloudflare-kv-asset-handler-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-miniflare-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-cloudflare-pages-shared-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-cloudflare-vitest-pool-workers-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-cloudflare-workers-editor-shared-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-cloudflare-workers-shared-7002npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12240002379/npm-package-cloudflare-workflows-shared-7002Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
e5e2db7 to
6eea915
Compare
cbb4b61 to
6eea915
Compare
|
picking this up to shepherd across the finish line 💟 |
6eea915 to
4666749
Compare
| isValid = false; | ||
|
|
||
| diagnostics.errors.push( | ||
| `"${field}" field should use hyphens (-) rather than en-dashes (—) or em-dashes (–).` |
There was a problem hiding this comment.
Is there a better way to demonstrate this, given that all three look identical in monospace fonts? Maybe there isn't, but I thought I would challenge it just because it reads very strangely in the terminal.
There was a problem hiding this comment.
not that I can tell I'm afraid. I totes get what you mean, and I did look into it, but it doesn't seem to be possible for us to control how the user's terminal will display these things.
There was a problem hiding this comment.
NP! Thanks for looking into it.
4666749 to
d25e501
Compare
…ibility date (#7002) * Add more helpful error messages when validating compatibility date * PR feedback --------- Co-authored-by: Carmen Popoviciu <cpopoviciu@cloudflare.com>
What this PR solves / how to test
Fixes WC-2854.
Author has addressed the following