Skip to content

feat (C3): Remove a bindings snippet for Hono template#6481

Merged
CarmenPopoviciu merged 6 commits intocloudflare:mainfrom
roottool:feature/remove-binding-snippet-for-hono
Aug 15, 2024
Merged

feat (C3): Remove a bindings snippet for Hono template#6481
CarmenPopoviciu merged 6 commits intocloudflare:mainfrom
roottool:feature/remove-binding-snippet-for-hono

Conversation

@roottool
Copy link
Copy Markdown
Contributor

@roottool roottool commented Aug 13, 2024 •
edited
Loading

What this PR solves / how to test

This PR Fixes honojs/hono#3193.
Until Hono v4.4.13, an interface was not available for bindings. ref. #5675
Since Hono v4.5.0, it can pass an interface. So we can remove that snippet and pass the CloudflareBindings directly.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: This PR only updates the C3 template for hono.
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: The Hono template has not tested.
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation

@roottool roottool requested a review from a team August 13, 2024 13:44
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2e738eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@roottool roottool mentioned this pull request Aug 13, 2024
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10384193221/npm-package-wrangler-6481

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6481/npm-package-wrangler-6481

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10384193221/npm-package-wrangler-6481 dev path/to/script.js
Additional artifacts: 
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10384193221/npm-package-create-cloudflare-6481 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10384193221/npm-package-cloudflare-kv-asset-handler-6481
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10384193221/npm-package-miniflare-6481
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10384193221/npm-package-cloudflare-pages-shared-6481
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10384193221/npm-package-cloudflare-vitest-pool-workers-6481
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10384193221/npm-package-cloudflare-workers-editor-shared-6481
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10384193221/npm-package-cloudflare-workers-shared-6481

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.71.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

CarmenPopoviciu
CarmenPopoviciu reviewed Aug 14, 2024
View reviewed changes
roottool and others added 2 commits August 14, 2024 17:28
@CarmenPopoviciu
Copy link
Copy Markdown
Contributor

CarmenPopoviciu commented Aug 14, 2024

LGTM! @yusukebe does this look good on your side as well?

yusukebe
yusukebe approved these changes Aug 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Copy Markdown
Contributor

yusukebe commented Aug 14, 2024

@CarmenPopoviciu yes!

@roottool Great work! Thank you!

@CarmenPopoviciu
Copy link
Copy Markdown
Contributor

CarmenPopoviciu commented Aug 14, 2024

fantastic! much awesomeness @roottool !! thank you for your contribution. I'll try to get the CI green and have this merged in ♥️

@CarmenPopoviciu CarmenPopoviciu self-assigned this Aug 14, 2024
@CarmenPopoviciu CarmenPopoviciu merged commit 83083d7 into cloudflare:main Aug 15, 2024
@roottool roottool deleted the feature/remove-binding-snippet-for-hono branch August 15, 2024 07:26
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Aug 15, 2024
@holopin-bot
Copy link
Copy Markdown

holopin-bot bot commented Aug 15, 2024

Congratulations @roottool, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/clzuyj04040240cmgkwitmgir

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@workers-devprod workers-devprod mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

+2 more reviewers

@yusukebe yusukebe yusukebe approved these changes

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@CarmenPopoviciu CarmenPopoviciu

Labels

contribution [Holopin] Recognizes an open-source contribution, big or small

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the C3 behavior for Cloudflare Workers template

5 participants

@roottool @CarmenPopoviciu @yusukebe @petebacondarwin @workers-devprod