🦋 Changeset detected

Latest commit: 9188267

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8787108403/npm-package-wrangler-5675

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5675/npm-package-wrangler-5675

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8787108403/npm-package-wrangler-5675 dev path/to/script.js

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8787108403/npm-package-create-cloudflare-5675 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8787108403/npm-package-cloudflare-kv-asset-handler-5675

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8787108403/npm-package-miniflare-5675

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8787108403/npm-package-cloudflare-pages-shared-5675

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8787108403/npm-package-cloudflare-vitest-pool-workers-5675

wrangler@3.51.2 includes the following runtime dependencies:

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@jculvey Looking at your generated repo at https://github.com/jculvey/cf-hono-example, everything on env is now unknown, so for example:

c.env.ddd

in your repo doesn't throw any errors, it just reports as unknown. Vs with a more traditional bindings definition, you end up with a useful error that tells you it doesn't exist on env:

Property 'ddd' does not exist on type 'CloudflareBindings'.ts(2339)

Is this the intent here? I feel like the DX is much worsened when everything on env is unknown.

Was this added as a result of using an interface to define bindings, instead of a type? And then to make that pass the Record<string, unknown> type Hono requires for Bindings, Record<string, unknown> & CloudflareBindings had to be added? If CloudflareBindings is just a type instead of an interface, everything works as I would expect and provides significantly better DX, imo, reporting when I try and access something on env that doesn't exist, actually as an error.

@Cherry thanks for catching this!

In short, no, the intent here wasn't just to regress the type safety of env 😅 .

In short we're trying to simplify the process of consuming the type definition generated by wrangler types for hono to bring it in line with the rest of the C3 templates.

Unfortunately If you try to assign the result of that command directly to Bindings you end up with this error:

As you point out, if the generated CloudflareBindings was a type and not an interface, there wouldn't be an issue.

What I was trying to accomplish was to augment the existing type with the generated one:

Agreed this is worse DX. I'll make a PR to patch this up. Thanks again for the report!

Thanks @jculvey! 🧡