Skip to content

fix: add a helpful message on Windows when Miniflare fails to start#6471

Merged
petebacondarwin merged 1 commit intomainfrom
warn-on-windows-error
Aug 15, 2024
Merged

fix: add a helpful message on Windows when Miniflare fails to start#6471
petebacondarwin merged 1 commit intomainfrom
warn-on-windows-error

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin commented Aug 12, 2024

What this PR solves / how to test

Fixes #6170

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: 819de03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10358943783/npm-package-wrangler-6471

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6471/npm-package-wrangler-6471

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10358943783/npm-package-wrangler-6471 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10358943783/npm-package-create-cloudflare-6471 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10358943783/npm-package-cloudflare-kv-asset-handler-6471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10358943783/npm-package-miniflare-6471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10358943783/npm-package-cloudflare-pages-shared-6471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10358943783/npm-package-cloudflare-vitest-pool-workers-6471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10358943783/npm-package-cloudflare-workers-editor-shared-6471
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10358943783/npm-package-cloudflare-workers-shared-6471

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.70.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Copy Markdown
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

@petebacondarwin petebacondarwin marked this pull request as ready for review August 15, 2024 07:29
@petebacondarwin petebacondarwin requested a review from a team as a code owner August 15, 2024 07:29
@petebacondarwin petebacondarwin merged commit 0d85f24 into main Aug 15, 2024
@petebacondarwin petebacondarwin deleted the warn-on-windows-error branch August 15, 2024 07:29
petebacondarwin added a commit that referenced this pull request Aug 16, 2024
… if there is an actual access violation

Replaces #6471, which was too verbose.

Fixes #6170
petebacondarwin added a commit that referenced this pull request Aug 16, 2024
… if there is an actual access violation (#6508)

Replaces #6471, which was too verbose.

Fixes #6170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

🐛 BUG: Received structured exception #0xc0000005: access violation;

3 participants