Skip to content

Revert "startDevWorker - Milestone 1"#4531

Merged
mrbbot merged 1 commit intomainfrom
revert-4497-startDevWorker-release
Nov 30, 2023
Merged

Revert "startDevWorker - Milestone 1"#4531
mrbbot merged 1 commit intomainfrom
revert-4497-startDevWorker-release

Conversation

@mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Nov 30, 2023

Reverts #4497

@mrbbot mrbbot requested a review from a team as a code owner November 30, 2023 16:24
@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2023

⚠️ No Changeset found

Latest commit: a314bea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023 •
edited
Loading

A create-cloudflare (C3) prerelease is available for testing.
You can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs//npm-package-create-cloudflare-

Note that these links will no longer work once the GitHub Actions artifact expires.

@codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Merging #4531 (a314bea) into main (f20b02a) will decrease coverage by 0.18%.
The diff coverage is 15.83%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4531      +/-   ##
==========================================
- Coverage   75.44%   75.26%   -0.18%     
==========================================
  Files         240      226      -14     
  Lines       12851    12570     -281     
  Branches     3309     3261      -48     
==========================================
- Hits         9695     9461     -234     
+ Misses       3156     3109      -47
Files Coverage Δ
packages/wrangler/src/api/index.ts 100.00% <ø> (ø)
packages/wrangler/src/dev.tsx 82.40% <ø> (+0.40%) ⬆️
packages/wrangler/src/https-options.ts 100.00% <100.00%> (ø)
packages/wrangler/src/api/dev.ts 82.85% <80.00%> (ø)
packages/wrangler/src/dev/miniflare.ts 55.10% <90.90%> (-4.81%) ⬇️
packages/wrangler/src/dev/start-server.ts 79.09% <71.42%> (+1.06%) ⬆️
packages/wrangler/src/dev/remote.tsx 8.24% <15.38%> (-0.05%) ⬇️
packages/wrangler/src/dev/local.tsx 22.68% <12.50%> (-3.25%) ⬇️
packages/wrangler/src/dev/inspect.ts 5.27% <5.69%> (-1.15%) ⬇️

... and 4 files with indirect coverage changes

@mrbbot mrbbot merged commit 310281a into main Nov 30, 2023
@mrbbot mrbbot deleted the revert-4497-startDevWorker-release branch November 30, 2023 16:35
mrbbot added a commit that referenced this pull request Nov 30, 2023
@mrbbot
Revert "Revert "startDevWorker - Milestone 1 (#4497)" (#4531)"
94eb4f3 
This reverts commit 310281a.
@mrbbot mrbbot mentioned this pull request Nov 30, 2023
Merged
mrbbot added a commit that referenced this pull request Nov 30, 2023
@mrbbot
Revert "Revert "startDevWorker - Milestone 1 (#4497)" (#4531)" (#4535)
29df8e1 
This reverts commit 310281a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@1000hz 1000hz 1000hz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrbbot @1000hz