Skip to content

In non-interactive mode remove the skills installation message#14162

Merged
dario-piotrowicz merged 2 commits into
mainfrom
dario/14144/remove-skills-install-non-interactive-msg
Jun 3, 2026
Merged

In non-interactive mode remove the skills installation message#14162
dario-piotrowicz merged 2 commits into
mainfrom
dario/14144/remove-skills-install-non-interactive-msg

Conversation

@dario-piotrowicz

Copy link
Copy Markdown
Member

Fixes #14144

When Wrangler run in non interactive mode and it detected agents that it could install skills for, it would print a message such as:

Cloudflare agent skills are available for: <DETECTED_AGENTS>. Run wrangler in an interactive terminal to install them, or use '--install-skills' to install without prompting.

This message seems to be confusing and unhelpful so this PR removes it.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: self-explanatory behavior

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b960f6c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch
@cloudflare/wrangler-bundler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ask-bonk

ask-bonk Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

No remaining references to the removed message. The change is clean and correct:

  • The logger.log message is removed from the non-interactive branch (agents-skills-install.ts:90-96)
  • The metrics event and early return are preserved, so behavior is otherwise unchanged
  • The corresponding test assertion was removed
  • The changeset is present and correctly scoped to wrangler as a patch

The only thing I'd note is a stale test name at line 325 ("logs info and sends skills_install_skipped when TTY is false"), which no longer reflects the behavior since nothing is logged anymore. But that's a documentation/naming nit, not a logic, security, or correctness issue, and my instructions are to be pragmatic and not nitpick.

There are no actionable issues.

LGTM

github run

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@pkg-pr-new

pkg-pr-new Bot commented Jun 2, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/cloudflare/workers-sdk/create-cloudflare@14162

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/deploy-helpers@14162

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/kv-asset-handler@14162

miniflare

npm i https://pkg.pr.new/cloudflare/workers-sdk/miniflare@14162

@cloudflare/pages-shared

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/pages-shared@14162

@cloudflare/unenv-preset

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/unenv-preset@14162

@cloudflare/vite-plugin

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/vite-plugin@14162

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/vitest-pool-workers@14162

@cloudflare/workers-auth

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-auth@14162

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-editor-shared@14162

@cloudflare/workers-utils

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-utils@14162

wrangler

npm i https://pkg.pr.new/cloudflare/workers-sdk/wrangler@14162

@cloudflare/wrangler-bundler

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/wrangler-bundler@14162

commit: b960f6c

@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review June 2, 2026 17:21
@workers-devprod workers-devprod requested review from a team and emily-shen and removed request for a team June 2, 2026 17:22
@workers-devprod

workers-devprod commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Comment thread packages/wrangler/src/__tests__/agents-skills-install.test.ts
@dario-piotrowicz dario-piotrowicz requested a review from NuroDev June 3, 2026 00:29

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Jun 3, 2026
@dario-piotrowicz dario-piotrowicz merged commit 0bb2d55 into main Jun 3, 2026
73 of 74 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/14144/remove-skills-install-non-interactive-msg branch June 3, 2026 10:43
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Cloudflare skills install message does not make the recommended action clear

3 participants