[wrangler] Support null values in wrangler secret bulk#14019
Merged
james-elicx merged 3 commits intoMay 26, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: fd0683e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
…eletion Add support for setting secret values to null in bulk JSON input to delete secrets via the secrets-bulk endpoint's JSON Merge Patch (RFC 7396) semantics. The parseBulkInputToObject function now accepts an includeNull flag with overloaded signatures to preserve type safety for existing callers. Output now distinguishes between created and deleted secrets.
bfb5b2e to
8c4d69e
Compare
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
james-elicx
reviewed
May 26, 2026
Co-authored-by: James Anderson <james@eli.cx>
Show created and deleted counts conditionally instead of always printing both lines. Use 💥 emoji for delete operations. Show a no-op message when no secrets were created or deleted. Add test for empty input case.
james-elicx
approved these changes
May 26, 2026
workers-devprod
approved these changes
May 26, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
Merged
penalosa
pushed a commit
that referenced
this pull request
May 28, 2026
Co-authored-by: James Anderson <james@eli.cx>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of: #13964
Describe your change...
Add support for setting secret values to null in bulk JSON input to delete secrets via the secrets-bulk endpoint's JSON Merge Patch (RFC 7396) semantics. The parseBulkInputToObject function now accepts an includeNull flag with overloaded signatures to preserve type safety for existing callers. Output now distinguishes between created and deleted secrets.
A picture of a cute animal (not mandatory, but encouraged)