Skip to content

Update examples/test code to use correct chat completions format#14017

Merged
NuroDev merged 4 commits into
cloudflare:mainfrom
samscott89:sscott/fix-chat-model-types
May 26, 2026
Merged

Update examples/test code to use correct chat completions format#14017
NuroDev merged 4 commits into
cloudflare:mainfrom
samscott89:sscott/fix-chat-model-types

Conversation

@samscott89

@samscott89 samscott89 commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes input/output types for Workers AI model usage.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: existing tests covers it
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: just example code updated I think?

@changeset-bot

changeset-bot Bot commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4014c5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samscott89 samscott89 marked this pull request as ready for review May 22, 2026 20:13
@workers-devprod workers-devprod requested review from a team and penalosa and removed request for a team May 22, 2026 20:13
@workers-devprod

workers-devprod commented May 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]
devin-ai-integration Bot reviewed May 22, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk May 26, 2026
@pkg-pr-new

pkg-pr-new Bot commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/cloudflare/workers-sdk/create-cloudflare@14017

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/deploy-helpers@14017

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/kv-asset-handler@14017

miniflare

npm i https://pkg.pr.new/cloudflare/workers-sdk/miniflare@14017

@cloudflare/pages-shared

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/pages-shared@14017

@cloudflare/unenv-preset

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/unenv-preset@14017

@cloudflare/vite-plugin

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/vite-plugin@14017

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/vitest-pool-workers@14017

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-editor-shared@14017

@cloudflare/workers-utils

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-utils@14017

wrangler

npm i https://pkg.pr.new/cloudflare/workers-sdk/wrangler@14017

commit: 4014c5f

@NuroDev NuroDev added the ci:no-changeset-required Skip pull request checks for a valid changeset label May 26, 2026
NuroDev
NuroDev approved these changes May 26, 2026
View reviewed changes
Comment thread packages/devprod-status-bot/src/index.ts
Comment thread packages/vite-plugin-cloudflare/playground/external-workers/src/index.ts Outdated
@NuroDev NuroDev mentioned this pull request May 26, 2026
Merged
workers-devprod
workers-devprod approved these changes May 26, 2026
View reviewed changes

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 26, 2026
@NuroDev NuroDev enabled auto-merge (squash) May 26, 2026 09:13
@NuroDev NuroDev merged commit 73f918b into cloudflare:main May 26, 2026
50 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 26, 2026
penalosa pushed a commit that referenced this pull request May 28, 2026
@samscott89 @penalosa
Update examples/test code to use correct chat completions format (#14017
a56b197 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
@NuroDev NuroDev NuroDev approved these changes
@workers-devprod workers-devprod workers-devprod approved these changes
@penalosa penalosa Awaiting requested review from penalosa penalosa was automatically assigned from cloudflare/wrangler
+1 more reviewer
@thatsKevinJain thatsKevinJain thatsKevinJain approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci:no-changeset-required Skip pull request checks for a valid changeset

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samscott89 @workers-devprod @NuroDev @thatsKevinJain