Skip to content

Revert "Support stream (but keep pipeline backwards compatible) binding for Pipelines"#13847

Merged
penalosa merged 1 commit into
mainfrom
revert-13716-oli/pipelines_stream
May 7, 2026
Merged

Revert "Support stream (but keep pipeline backwards compatible) binding for Pipelines"#13847
penalosa merged 1 commit into
mainfrom
revert-13716-oli/pipelines_stream

Conversation

@penalosa

@penalosa penalosa commented May 7, 2026

Copy link
Copy Markdown
Contributor

@penalosa penalosa requested a review from workers-devprod as a code owner May 7, 2026 13:29
@penalosa penalosa added the ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials label May 7, 2026
@changeset-bot

changeset-bot Bot commented May 7, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cea1bad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk May 7, 2026
@workers-devprod workers-devprod requested review from a team and emily-shen and removed request for a team May 7, 2026 13:30
@workers-devprod

workers-devprod commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk

ask-bonk Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

The revert is complete and consistent across all files. This is a clean GitHub-generated revert of PR #13716, restoring the pipeline field name everywhere and removing the stream field and deprecation logic. No files were missed, and no remaining stream references in the context of pipeline bindings exist outside of the changed files.

LGTM

github run

@pkg-pr-new

pkg-pr-new Bot commented May 7, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13847

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13847

miniflare

npm i https://pkg.pr.new/miniflare@13847

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13847

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13847

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13847

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13847

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13847

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13847

wrangler

npm i https://pkg.pr.new/wrangler@13847

commit: cea1bad

@penalosa penalosa added the ci:skip-pr-description-validation Skip validation of the required PR description format label May 7, 2026
workers-devprod
workers-devprod approved these changes May 7, 2026
View reviewed changes

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 7, 2026
@penalosa penalosa merged commit cf09891 into main May 7, 2026
70 of 98 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 7, 2026
@penalosa penalosa deleted the revert-13716-oli/pipelines_stream branch May 7, 2026 13:55
oliy added a commit that referenced this pull request May 7, 2026
@oliy
Support stream (but keep pipeline backwards compatible) binding for P…
bd3cc65 
…ipelines (#13847)

This reverts commit cf09891.
oliy added a commit that referenced this pull request May 7, 2026
@oliy
Support stream (but keep pipeline backwards compatible) binding for P…
6bcd95d 
…ipelines (#13847)

This reverts commit cf09891.
oliy added a commit that referenced this pull request May 12, 2026
@oliy
Support stream (but keep pipeline backwards compatible) binding for P…
0b9b309 
…ipelines (#13847)

This reverts commit cf09891.
oliy added a commit that referenced this pull request May 12, 2026
@oliy
Support stream (but keep pipeline backwards compatible) binding for P…
a4ed9d6 
…ipelines (#13847)

This reverts commit cf09891.
petebacondarwin pushed a commit that referenced this pull request May 13, 2026
@oliy @petebacondarwin
Support stream (but keep pipeline backwards compatible) binding for P…
bfd1312 
…ipelines (#13847)

This reverts commit cf09891.
oliy added a commit that referenced this pull request May 14, 2026
@oliy
Support stream (but keep pipeline backwards compatible) binding for P…
328dae5 
…ipelines (#13847)

This reverts commit cf09891.
petebacondarwin pushed a commit that referenced this pull request May 14, 2026
@oliy @petebacondarwin
Support stream (but keep pipeline backwards compatible) binding for P…
2fed22c 
…ipelines (#13847)

This reverts commit cf09891.
petebacondarwin pushed a commit that referenced this pull request May 14, 2026
@oliy @petebacondarwin
Support stream (but keep pipeline backwards compatible) binding for P…
d7e3e1b 
…ipelines (#13847)

This reverts commit cf09891.
oliy added a commit that referenced this pull request May 22, 2026
@oliy
Support stream (but keep pipeline backwards compatible) binding for P…
6626bc2 
…ipelines (#13847)

This reverts commit cf09891.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NuroDev NuroDev NuroDev approved these changes
@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes
@workers-devprod workers-devprod workers-devprod approved these changes
@emily-shen emily-shen Awaiting requested review from emily-shen emily-shen was automatically assigned from cloudflare/wrangler

Assignees

No one assigned

Labels

ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials ci:skip-pr-description-validation Skip validation of the required PR description format

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@penalosa @workers-devprod @NuroDev @dario-piotrowicz