Skip to content

[wrangler] Disable Sentry error reporting by default#13815

Merged
NuroDev merged 2 commits into
mainfrom
penalosa/disable-sentry
May 26, 2026
Merged

[wrangler] Disable Sentry error reporting by default#13815
NuroDev merged 2 commits into
mainfrom
penalosa/disable-sentry

Conversation

@penalosa

@penalosa penalosa commented May 5, 2026

Copy link
Copy Markdown
Contributor

WRANGLER_SEND_ERROR_REPORTS now defaults to false instead of undefined. Previously, when the env var was unset, Wrangler would prompt the user on every error asking whether to report to Sentry. The prompt produces too many false-positive reports, so we now default to off. Users can still opt in by setting WRANGLER_SEND_ERROR_REPORTS=true.

A follow-up PR will remove the Sentry codepaths.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: `WRANGLER_SEND_ERROR_REPORTS` is an internal/opt-in env var and the user-facing behavioural change is "we no longer prompt you to send error reports".

@changeset-bot

changeset-bot Bot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b5da47f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ask-bonk

ask-bonk Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

LGTM

github run

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@pkg-pr-new

pkg-pr-new Bot commented May 5, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/cloudflare/workers-sdk/create-cloudflare@13815

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/deploy-helpers@13815

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/kv-asset-handler@13815

miniflare

npm i https://pkg.pr.new/cloudflare/workers-sdk/miniflare@13815

@cloudflare/pages-shared

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/pages-shared@13815

@cloudflare/unenv-preset

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/unenv-preset@13815

@cloudflare/vite-plugin

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/vite-plugin@13815

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/vitest-pool-workers@13815

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-editor-shared@13815

@cloudflare/workers-utils

npm i https://pkg.pr.new/cloudflare/workers-sdk/@cloudflare/workers-utils@13815

wrangler

npm i https://pkg.pr.new/cloudflare/workers-sdk/wrangler@13815

commit: b5da47f

penalosa added 2 commits May 26, 2026 14:58
The current Sentry consent prompt fires on every error and produces too many
false-positive reports. Default WRANGLER_SEND_ERROR_REPORTS to false so we
neither prompt nor send by default. Users can still opt in by setting
WRANGLER_SEND_ERROR_REPORTS=true.
- Drop the prompt output from the non-interactive 'should not hit sentry
  after error' snapshot (the consent prompt no longer fires by default).
- Remove the two tests that exercised the consent prompt path: that path
  is no longer reachable because WRANGLER_SEND_ERROR_REPORTS now defaults
  to false rather than undefined. The remaining tests already cover both
  the explicit-true and explicit-false env var cases.
@penalosa penalosa force-pushed the penalosa/disable-sentry branch from d33b3af to b5da47f Compare May 26, 2026 12:58
@penalosa penalosa marked this pull request as ready for review May 26, 2026 18:52
@penalosa penalosa requested a review from workers-devprod as a code owner May 26, 2026 18:52
@workers-devprod workers-devprod requested review from a team and dario-piotrowicz and removed request for a team May 26, 2026 18:52
@workers-devprod

workers-devprod commented May 26, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 26, 2026

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@NuroDev NuroDev merged commit 5fa3de6 into main May 26, 2026
63 of 64 checks passed
@NuroDev NuroDev deleted the penalosa/disable-sentry branch May 26, 2026 20:56
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants