Skip to content

EMAIL-1692 Support RFC5322 Name formats for To/Cc/Bcc Addresses#13738

Merged
emily-shen merged 1 commit into
cloudflare:mainfrom
Skye-31:skye/EMAIL-1692/rfc5322-to-cc-bcc-formats
May 5, 2026
Merged

EMAIL-1692 Support RFC5322 Name formats for To/Cc/Bcc Addresses#13738
emily-shen merged 1 commit into
cloudflare:mainfrom
Skye-31:skye/EMAIL-1692/rfc5322-to-cc-bcc-formats

Conversation

@Skye-31

@Skye-31 Skye-31 commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Fixes EMAIL-1692.

This change implements support for RFC5322 addresses in the to/cc/bcc fields of Email Sending, like we do for From/ReplyTo, as well as improving some of the test coverage around this.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Will be done after both this change and the corresponding change in the runtime are released

Open in Devin Review

@changeset-bot

changeset-bot Bot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f9e8a05

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Apr 29, 2026
@workers-devprod workers-devprod requested review from a team and ascorbic and removed request for a team April 29, 2026 17:50
@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/workers/email/send_email.worker.ts: [@cloudflare/wrangler]
  • packages/miniflare/src/workers/email/types.ts: [@cloudflare/wrangler]
  • packages/miniflare/test/plugins/email/index.spec.ts: [@cloudflare/wrangler]

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@pkg-pr-new

pkg-pr-new Bot commented Apr 29, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13738

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13738

miniflare

npm i https://pkg.pr.new/miniflare@13738

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13738

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13738

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13738

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13738

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13738

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13738

wrangler

npm i https://pkg.pr.new/wrangler@13738

commit: f9e8a05

@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 5, 2026
@emily-shen emily-shen merged commit 2d51b09 into cloudflare:main May 5, 2026
64 of 67 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 5, 2026
Skye-31 added a commit to Skye-31/workers-sdk that referenced this pull request May 6, 2026
The way logs are collected in miniflare tests changed slightly between
when the first PR (cloudflare#13738)
had it's checks run, and it getting merged. This caused CI to fail after
it got merged.

This commit applies just the minimal fixes to the tests, keeping the
prior approved changes in a separate commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants