🦋 Changeset detected

Latest commit: 5d38f9e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Codeowners approval required for this PR:

• ✅ @cloudflare/wrangler

✅ All changesets look good

I've now reviewed the entire PR. Let me check the error message wording closely:

• NonExistentAssetsDirError: "The directory specified by the ..." — uses "--assets" command line argument
• NonDirectoryAssetsDirError: "The path specified by the ..." — uses "--assets" command line argument

But looking at the test expectations more carefully:

• The deploy test for --assets expects: The path specified by the "--assets" command line argument doesn't point to a directory
• The dev test for --assets expects: The path specified by the "--assets" command line argument doesn't point to a directory

The wording is consistent between tests and source. The existing error says "directory specified by" while the new one says "path specified by" — this is appropriate since in the new case it's not a directory.

Let me now verify the behavior at the getPlatformProxy call site. The new NonDirectoryAssetsDirError would correctly NOT be caught by the instanceof NonExistentAssetsDirError check, which is the right behavior — a file existing at that path is a user error that should surface.

The overall change is clean:

1. Replaces existsSync with statSync (single syscall instead of two)
2. Adds early detection for non-directory paths
3. Proper error class hierarchy
4. Good test coverage for both dev and deploy commands, both CLI flag and config file sources
5. Formatter line-break changes are cosmetic (likely from oxfmt)
6. Changeset is correct

LGTM

github run

npm i https://pkg.pr.new/create-cloudflare@13115

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13115

npm i https://pkg.pr.new/miniflare@13115

npm i https://pkg.pr.new/@cloudflare/pages-shared@13115

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13115

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13115

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13115

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13115

npm i https://pkg.pr.new/wrangler@13115

commit: 5d38f9e