Skip to content

Add support for connect handler in vitest and vite tests#12802

Closed
fhanau wants to merge 1 commit intomainfrom
felix/030526-connect-handler-p2
Closed

Add support for connect handler in vitest and vite tests#12802
fhanau wants to merge 1 commit intomainfrom
felix/030526-connect-handler-p2

Conversation

@fhanau
Copy link
Copy Markdown
Contributor

@fhanau fhanau commented Mar 7, 2026 •
edited
Loading

Follow-up to #12775 and part of EW-9330. Updates tests so that the connect handler is marked as reserved and as a potential member of the WorkerEntrypoint class. Needs cloudflare/workerd#6059 to land first, which in turn requires #12775. Other PRs have landed, just need to update to workerd
v1.20260324.1 (or higher) first.

  • Tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Feature is behind experimental compat flag for now.
Open with Devin

@fhanau fhanau requested a review from a team as a code owner March 7, 2026 20:12
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 7, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: d376be4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 7, 2026
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 7, 2026

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/src/shared/external-service.ts: [@cloudflare/wrangler]
  • packages/vite-plugin-cloudflare/src/workers/runner-worker/keys.ts: [@cloudflare/wrangler]
  • packages/vitest-pool-workers/src/worker/entrypoints.ts: [@cloudflare/wrangler]

@fhanau fhanau mentioned this pull request Mar 7, 2026
Merged
5 tasks
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 7, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12802

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12802

miniflare

npm i https://pkg.pr.new/miniflare@12802

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12802

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12802

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12802

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12802

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12802

wrangler

npm i https://pkg.pr.new/wrangler@12802

commit: d376be4

devin-ai-integration[bot]
devin-ai-integration bot reviewed Mar 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

fhanau
fhanau commented Mar 9, 2026
View reviewed changes
@fhanau fhanau force-pushed the felix/030526-connect-handler-p2 branch from 352756b to 8046582 Compare March 24, 2026 02:41
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 24, 2026

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/vite-plugin-cloudflare/src/workers/runner-worker/keys.ts: [@cloudflare/wrangler]
  • packages/vitest-pool-workers/src/worker/entrypoints.ts: [@cloudflare/wrangler]

devin-ai-integration[bot]
devin-ai-integration bot reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 4 additional findings in Devin Review.

Open in Devin Review

@fhanau fhanau force-pushed the felix/030526-connect-handler-p2 branch from 8046582 to d376be4 Compare March 24, 2026 14:09
@fhanau
Copy link
Copy Markdown
Contributor Author

fhanau commented Mar 30, 2026

The changes here are already included in the current draft of #13111, this PR can be dropped if that goes ahead.

@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Mar 30, 2026

The changes here are already included in the current draft of #13111, this PR can be dropped if that goes ahead.

Yep. As soon as that PR is green I'll get it merged and we can drop this one. Thanks

@petebacondarwin petebacondarwin mentioned this pull request Mar 30, 2026
Merged
@petebacondarwin petebacondarwin self-assigned this Mar 30, 2026
@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

@petebacondarwin petebacondarwin

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fhanau @workers-devprod @petebacondarwin