Add support for worker connect handler in miniflare#12775
Conversation
🦋 Changeset detectedLatest commit: e3d301d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/vite-plugin-cloudflare/src/workers/runner-worker/keys.ts
Outdated
Show resolved
Hide resolved
71b8572 to
76b05e4
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
e2dff1c to
270bd12
Compare
|
Codeowners approval required for this PR:
Show detailed file reviewers |
jamesopstad
left a comment
There was a problem hiding this comment.
Please could you add a changeset. It can just describe the change very briefly.
This is a one-line change for a test to enable a feature in another repo that won't be available externally for now. I can add a change set, but wouldn't this be the kind of PR that doesn't require one? |
What do you mean about it being a "change for a test"? We generally add changesets for any change that should trigger a version bump and release. |
This is needed to add initial support for the connect handler in workerd (experimental-only for now).
b80577f to
e3d301d
Compare
|
Right, the change here isn't test-only, that's case with the follow-up change in #12802. Corrected the PR and commit title and added a change set. |
|
File:
|
|
This is needed to add initial support for the connect handler in workerd (experimental-only for now).
Part of EW-9330. Updates miniflare so that the connect handler is marked as reserved. This is needed for cloudflare/workerd#6059 to land, additional changes are included in #12802 which needs the workerd PR to be merged first. This PR should be sufficient for allowing the workerd PR to land: Reordering the steps in workerd CI shows that while miniflare tests are failing, vite and vitest tests are not so this one change should be sufficient to allow merging the workerd PR.