fix(miniflare): support WebSocket proxying over dev registry#10273
Merged
edmundhung merged 1 commit intomainfrom Aug 8, 2025
Merged
fix(miniflare): support WebSocket proxying over dev registry#10273edmundhung merged 1 commit intomainfrom
edmundhung merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 9b0d4ec The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
413edbd to
8897ef2
Compare
8897ef2 to
9b0d4ec
Compare
petebacondarwin
approved these changes
Aug 8, 2025
| const statusLine = `HTTP/1.1 ${upRes.statusCode ?? 101} ${upRes.statusMessage ?? "Switching Protocols"}\r\n`; | ||
| let headersString = ""; | ||
| for (let i = 0; i < upRes.rawHeaders.length; i += 2) { | ||
| headersString += `${upRes.rawHeaders[i]}: ${upRes.rawHeaders[i + 1]}\r\n`; |
Contributor
There was a problem hiding this comment.
OOC is the \r\n rather than just \n to ensure it is valid on Windows?
Member
Author
There was a problem hiding this comment.
It's just because the HTTP/1.1 Spec requires these lines to be terminated with CLRF (\r\n): https://datatracker.ietf.org/doc/html/rfc7230#section-3
| wsResponse.webSocket.accept(); | ||
|
|
||
| // Test bidirectional communication | ||
| wsResponse.webSocket.send("ping"); |
Contributor
There was a problem hiding this comment.
Is there a chance that this ping will cause a response before you have setup the listener?
Member
Author
There was a problem hiding this comment.
Good call. I will move this after the messagePromise in a follow up PR.
Member
Author
Merged
edmundhung
added a commit
that referenced
this pull request
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes n/a.