Add preview metadata to buffered tail traces#6375
Merged
ketanhwr merged 1 commit intocloudflare:mainfrom Mar 30, 2026
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Ankcorn
commented
Mar 20, 2026
jp4a50
reviewed
Mar 24, 2026
fb12ef3 to
4dddab3
Compare
Member
Author
|
I have read the CLA Document and I hereby sign the CLA |
Member
Author
|
recheck |
jp4a50
approved these changes
Mar 25, 2026
Merging this PR will improve performance by 25.64%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | bodyWithHeaders[Response] |
38.7 µs | 30.8 µs | +25.64% |
Comparing Ankcorn:tankcorn/preview-observability (35cc683) with main (ecfaecd)
Footnotes
-
129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
jasnell
approved these changes
Mar 27, 2026
827d7da to
5533538
Compare
4c9390f to
19ceb82
Compare
petebacondarwin
requested changes
Mar 30, 2026
19ceb82 to
feefba4
Compare
petebacondarwin
approved these changes
Mar 30, 2026
5a3549e to
76c1ced
Compare
76c1ced to
35cc683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add preview metadata to buffered tail traces.
This exposes:
to classic/buffered tail workers.
Why Why
edgeworker needs to surface pipeline-level preview identity in classic tail worker
observability.
That requires workerd to support carrying preview metadata through the buffered trace path;
otherwise classic tail workers only receive traces without any preview context.
Changes
Notes
This only adds the workerd support layer. The corresponding edgeworker change is what populates
this field from pipeline preview metadata.